From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: Andreas Schwab <schwab@suse.de>, "emacs-devel" <emacs-devel@gnu.org>
Subject: Re: Some Emacs outside Emacs
Date: Fri, 29 Jul 2022 10:37:04 -0400 [thread overview]
Message-ID: <jwvv8rg7zt9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wnbx39vl.fsf@elite.giraud> (Manuel Giraud's message of "Thu, 28 Jul 2022 10:43:42 +0200")
> --8<---------------cut here---------------start------------->8---
> Lisp_Object frame;
> XFontSet fs;
>
> frame = menu_bar_to_frame(mw);
> if (FRAMEP (frame))
> fs = FRAME_XIC_FONTSET (XFRAME (frame));
> --8<---------------cut here---------------end--------------->8---
Style comment: I recommend you try to initialize your variables directly
in their declaration, as in:
Lisp_Object frame = menu_bar_to_frame(mw);
XFontSet fs = (FRAMEP (frame)
? FRAME_XIC_FONTSET (XFRAME (frame))
: ...);
This eliminates the possibility of having the variable be uninitialized,
and reduces the "risk" of leaving a unused variable declaration.
It also often results in more concise code.
Stefan
next prev parent reply other threads:[~2022-07-29 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 6:33 Some Emacs outside Emacs Manuel Giraud
2022-07-28 7:53 ` Eli Zaretskii
2022-07-28 7:55 ` Andreas Schwab
2022-07-28 8:43 ` Manuel Giraud
2022-07-29 14:37 ` Stefan Monnier [this message]
2022-07-28 8:39 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv8rg7zt9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).