From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 8bf4cdcf79: Avoid recursive process filters in lisp/jsonrpc.el (bug#60088) Date: Fri, 16 Dec 2022 09:36:02 -0500 Message-ID: References: <167118072395.30479.8819833637573037468@vcs2.savannah.gnu.org> <20221216085204.43B07C04961@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20713"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 16 15:36:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6Bpa-0005Ee-HO for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Dec 2022 15:36:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6Boz-00058Y-Kf; Fri, 16 Dec 2022 09:36:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Bov-000582-M6 for emacs-devel@gnu.org; Fri, 16 Dec 2022 09:36:17 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Bos-0003yl-Tn for emacs-devel@gnu.org; Fri, 16 Dec 2022 09:36:17 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 02F1D1002B1; Fri, 16 Dec 2022 09:36:12 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3B698100126; Fri, 16 Dec 2022 09:36:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671201370; bh=oLxY5iRzaGulLmki7HaQpKZXWmHSCjOK6IjgDsfHZ5s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Iyga/6+/ri0nQRA5Dba/xnNY1VAkk6wpUCEVfuRzddguGqLOVZE2MKSjraE7B6R5I gbWISnY8myPMPTMWsLMyCkGoWS5he0ZskvnVsR4dtjxH00UFGZf+clghAYDCPOhyI7 gRl7Z+s2myDKbg3OPA7oGbOU12Z7czxtrsJkaDqyxTMSBtJzzpUaw8KG/sc1MyHwx6 U1pyQCECNB8rkvW9mbFCxuEYFGVju4wwEQKbxyGCTNM59BWmVFrdzkvU2jmM78eUTK 7TKItcpBRDVxB/uEDXNV4YrQYWbfGukQuc0ECS7WV8iNcEklWtcqS0f9FaXeVDDSzS UFAP5RnJeVjiA== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1016912039B; Fri, 16 Dec 2022 09:36:10 -0500 (EST) In-Reply-To: <20221216085204.43B07C04961@vcs2.savannah.gnu.org> (=?windows-1252?Q?=22Jo=E3o=09T=E1vora=22's?= message of "Fri, 16 Dec 2022 03:52:04 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301486 Archived-At: > Avoid recursive process filters in lisp/jsonrpc.el (bug#60088) BTW, this has bitten us in various other cases, we should fix it once and for all in the C code by marking the process as "busy" while we're running the filters so we never run filters recursively. [ If we ever bump into a case where recursive filters are needed, we can then add some function to remove the "busy" mark. Calling (accept-process-output PROC) should naturally mark PROC as not-busy. ] Stefan