From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Request to add Package to GNU ELPA Date: Thu, 06 Apr 2023 17:36:22 -0400 Message-ID: References: <87tty24ap2.fsf@bernoul.li> <87wn2y5em5.fsf@posteo.net> <87r0t44zbx.fsf@bernoul.li> <87sfde7lh4.fsf@posteo.net> <87lej6ju1m.fsf@bernoul.li> <875yaayyly.fsf@posteo.net> <87bkk2xcjz.fsf@posteo.net> <87pm8hf1z0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33491"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jonas Bernoulli , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 06 23:37:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkXI8-0008VC-Qc for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Apr 2023 23:37:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkXHU-00079c-Li; Thu, 06 Apr 2023 17:36:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkXHT-00079K-IF for emacs-devel@gnu.org; Thu, 06 Apr 2023 17:36:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkXHQ-0003mv-JQ for emacs-devel@gnu.org; Thu, 06 Apr 2023 17:36:31 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8D5D4808AF; Thu, 6 Apr 2023 17:36:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 217C28007C; Thu, 6 Apr 2023 17:36:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1680816985; bh=jGtKR/Pt61S3aZ8oPnCF+Swj09lFuQu7KsSzTkHGpR4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OnMl4wKjatVU0qnIMYY6tbTkbC3thNDGSC0UALSnH1+mj6rh+1+LNrZg6i3VkNbJj 1BlZoWbmXTPLgfwPI90J9i/pxwxMGHnQID9Ojo2S+dKy7SGqNqqv97BRsNYtWPuU41 BBvTeSR3lH2S2o2tDrOib1ahrUt8mpcr0Z4nYqhmnLE0HBmOmVjEh+2tXddAya6Ljc ua44ja0CadhyRt84lpIqGEwCHoF15B4acZOCDw2cpVFW5LUTgN0Ox6WNo3R03832pB 1R6lN+bR4ivNf+ZTRm81l3os+AcBPbhbnko6ZDvX1g6/xHqAzXkIVHcTgpjlbommPf JI/SWk+msWlLg== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E21F21233D1; Thu, 6 Apr 2023 17:36:24 -0400 (EDT) In-Reply-To: <87pm8hf1z0.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 06 Apr 2023 15:46:11 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305151 Archived-At: > +;; Package-Requires: ((emacs "26.1") (compat "29.1.0.0")) [ I'm curious which definitions of `compat` this uses. ] > @@ -1208,10 +1214,13 @@ package-buffer-info > :kind 'single > :url website > :keywords keywords > - :maintainer > + :maintainer (lm-maintainer) > ;; For backward compatibility, use a single string if there's only > ;; one maintainer (the most common case). > - (let ((maints (lm-maintainers))) (if (cdr maints) maints (car mai= nts))) > + (if (fboundp 'lm-maintainers) > + (let ((maints (lm-maintainers))) > + (if (cdr maints) maints (car maints))) > + (lm-maintainer)) > :authors (lm-authors))))) Hmm... isn't the `(lm-maintainer)` right after `:maintainer` erroneous? [ BTW, I think Jonas has another change pending for this code. ] > (when news > - (insert "\n" (make-separator-line) "\n" > - (propertize "* News" 'face 'package-help-section-name) > + (newline) > + (when (fboundp 'make-separator-line) > + (insert (make-separator-line)) > + (newline)) > + (insert (propertize "* News" 'face 'package-help-section-name) > "\n\n") > (insert-file-contents news)) Why not just replace (make-separator-line) with (if (fboundp 'make-separator-line) (make-separator-line) "")? `newline` is a command and I think it's preferable not to use it from ELisp. > @@ -4571,8 +4581,11 @@ package-report-bug > (dolist (ent (get (cdr group) 'custom-group)) > (when (and (custom-variable-p (car ent)) > (boundp (car ent)) > - (not (eq (custom--standard-value (car ent)) > - (default-toplevel-value (car ent)))) > + (not (eq > + ;; We are not using `custom--standard-value' > + ;; to retain compatibility for Emacs 27. > + (eval (car (get (car ent) 'standard-value)) t) > + (default-toplevel-value (car ent)))) I'd use (if (fboundp 'custom--standard-value) ;; Emacs=E2=89=A527 (custom--standard-value (car ent)) (eval (car (get (car ent) 'standard-value)) t)) so the code "speaks for itself". Stefan