> And here I was thinking that I had fixed all of the byte compilation
>  problems.. Turns out it was only working because I byte compiled everything
>  within the same Emacs session.

:-)

> I made some changes and think things should
> be in order now. At least, the following shell script doesn't seem to
> result in any errors:
>
> for file in ./*.el; do
>     cask emacs -batch -L . --eval '(setq byte-compile-error-on-warn t)' -f
> batch-byte-compile "$file" || break
> done

Yay!
And you even saved kittens along the way!!!

> I see some warnings in your log that concern files in the "benchmark" and
> "test" directories.  These files are not required for the package to
> function.  Can these be excluded from the ELPA build somehow?

The log was for a compilation from the Git, not from the ELPA tarball,
but you can indeed exclude them from the ELPA tarball by listing those
elements in the `.elpaignore` file at the root of your package.

You can check the result at http://elpa.gnu.org/devel/phpinspect.html
(once it builds a tarball successfully).

> I have seen some projects use a "lisp" directory for their source
> code, is that the recommended approach for this?

No, it's unrelated.

BTW, here's another set of patches in you're interested.


        Stefan