From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Tue, 27 Feb 2024 12:49:51 -0500 Message-ID: References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> <87msrleuwd.fsf@eve> <87h6htu89t.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9869"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jay Kamat , Jeremy Bryant , "emacs-devel@gnu.org" To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 27 18:50:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rf1bR-0002OA-4q for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Feb 2024 18:50:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf1ab-0002Kx-A8; Tue, 27 Feb 2024 12:50:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf1aY-0002Ke-K2 for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:49:59 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf1aW-0006RN-Rp for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:49:58 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DAB5644385F; Tue, 27 Feb 2024 12:49:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1709056193; bh=9vB2pFiB31BNL3TH/VOO4hqt7v7WepUhN1KB3gNawMg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dEq3fscyNkTnXrnSy/ME0OFOxH/QOReGEB940zP+H1jQgxDsp8QY4Xkl0qtNNX8nR FJHlMeozQsSnJP47vCGAo3kRu2zOR8+cD2cDAxkPSh4GoZAMrHN8vAinYYcPsquSc1 /FhnjUB0GVpiGfuttLv9wY9ZDzpEUiIUr/mwzIqea9ei8mkb3urgxVUmTjd3fdK53t wAg7yh8CfAsvkEW9U/UTOmFUWD71/R1j/FyuTrfOU7mUdUqL2SxjQNr1ug/GIoSotr M0O2fi6FsYxa8lsbrS77yOvMSS1QlXE8jKaqpccKqv4m4B4BSvWXXOTb89nWm+0PZd FL3mzq337ko5w== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7E35E44386E; Tue, 27 Feb 2024 12:49:53 -0500 (EST) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5DC4912023D; Tue, 27 Feb 2024 12:49:53 -0500 (EST) In-Reply-To: <87h6htu89t.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 27 Feb 2024 17:27:58 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316598 Archived-At: >> I haven't looked at the code but I'll point out that >> `convert-standard-filename` is meant to *define* the name of a "standard" >> file, so its argument is usually very static. >> It doesn't make sense to apply it to something like `buffer-file-name` >> which is already supposed to be a valid filename. > > In that case I must have misunderstood something, my intention was to > find a function that would convert file names with forwards slashes to > the proper file delimiters on the current system. No, `convert-standard-filename` is useful when you got some string from somewhere and you'd like to generate a valid file name from that. Usually the string is an almost constant like "~/.emacs" and the purpose is to deal with quirks like when file names can't start with a dot or can't include a colon. I can't help much more on if/when/how to convert an internal filename into one that works in a win32 shell, 'cause I have no experience with that. AFAICT most ELisp code doesn't do anything special for that (whereas they sometimes do such things for Tramp purposes), so I'd naively expect that it "just works". >> Also I think `shell-quote-argument` should be applied to most parts of >> `rmsbolt--demangle-command`. This function is also odd in that it >> calls `rmsbolt--convert-file-name-to-system-type` on the files >> of the demangler but not those of the `mv`. > > IIUC shell-quote-argument cannot be used, Of course it can. You can't just replace the #'identity with #'shell-quote-argument, indeed, but still `shell-quote-argument` should be used on *most* parts that appear in the function. Stefan