From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Turning on/off tree-sitter modes Date: Sat, 30 Nov 2024 13:49:42 -0500 Message-ID: References: <4cc676e8-cac5-4348-99b0-243baf74687e@gutov.dev> <8634jnt5e3.fsf@gnu.org> <4864104c-cb23-4356-ad89-2fea111db66c@gutov.dev> <86ttc2rrh8.fsf@gnu.org> <86cyipsp94.fsf@gnu.org> <9cd17f8b-f88c-49f6-9024-0b6d297e18ac@gutov.dev> <867c8xsmri.fsf@gnu.org> <566ac897-ea5e-4141-bcb3-306d43c9118a@gutov.dev> <865xohrvfa.fsf@gnu.org> <86wmgwnyle.fsf@gnu.org> <178dfc7f-bc2d-4e3b-8417-a616ccc0eef3@gutov.dev> <86v7wgnxlz.fsf@gnu.org> <01d83ec8-c02b-4806-8764-38dc89a89125@gutov.dev> <86ttbzojho.fsf@gnu.org> <930f5c8e-1481-43a5-8f1d-2c13a98df74f@gutov.dev> <86r072krq5.fsf@gnu.org> <27a62624-387c-4233-b995-170270e26efd@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35128"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 30 19:50:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHSY4-0008zn-UZ for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Nov 2024 19:50:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHSXP-0006lh-2z; Sat, 30 Nov 2024 13:49:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHSXN-0006lW-Ix for emacs-devel@gnu.org; Sat, 30 Nov 2024 13:49:49 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHSXL-0006py-QN for emacs-devel@gnu.org; Sat, 30 Nov 2024 13:49:49 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 14173440C1C; Sat, 30 Nov 2024 13:49:45 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1732992583; bh=0tb+s10vU5jshTNs6eXlRwm20fDzRTzLNbXELTXu35A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OUUGgYFjN6ltcMn7x9i2EUshCXUEpVbCFPcmyi+T9o2KmxrOrPGhzekZKB94dtGpd 1Mt87y6EspvJh1+BMB5E2AnHuBKia5ivGeS9Vz/eBCPEDozeXNWFQYLgWWFL4pC9Vv Mwc42i3LRwoENjCCVEGVZ3rCJoINqMAf2Fr9UGKjO4XQHzjAyVJOHWkYTo1Az75PWl ZECZBuJnv2Nn9aZs+N2taAPYmNGrrZQ57bwKSVF0ziss25Pdvk6Ehqalsfs10r5k+M YzWNMImhAMKnK2nEILaOXBek1PJFM1jUoEeBFeoHYZuKptzQ7vGcFZbX1D8Rx7+B5D 4E9HqvFEjRYAw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AFCFA4427EE; Sat, 30 Nov 2024 13:49:43 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 87AA412024D; Sat, 30 Nov 2024 13:49:43 -0500 (EST) In-Reply-To: <27a62624-387c-4233-b995-170270e26efd@gutov.dev> (Dmitry Gutov's message of "Sat, 30 Nov 2024 05:26:35 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325888 Archived-At: >> In any case I was thinking of a UI that's not specific to tree-sitter >> that works as follows: >> (defun change-major-mode (newmode) >> (interactive (list (read-the-new-mode))) >> (cond >> ((eq major-mode (the-mode-normally-selected-by-auto-mode-alist)) >> (setf (alist-get major-mode major-mode-remap-alist) newmode) >> (when (called-interactively-p) >> (customize-mark-as-set 'major-mode-remap-alist))) >> (t >> (let ((regexp (guess-regexp buffer-file-name))) >> (add-to-list 'auto-mode-alist (cons regexp newmode)) >> (when (called-interactively-p) >> ...somehow convince Custom to do the above `add-to-list`...)))) >> (funcall newmode)) > > That sounds interesting, especially the 'guess-regexp' part. I think > it would make it ineligible for calling from the init script, though, > which could be a preference for many. It's definitely meant for interactive use, yes. For the init file, we have things like (add-to-list 'major-mode-remap-alist '(foo-mode . bar-mode)) so I don't see any need for anything new. >> `read-the-new-mode` could use a variable like Dmitry's >> `treesit--mode-associations` to provide good defaults. >> BTW, this var shouldn't be set like in his patch, IMO but via >> ###;;;autoload >> (add-to-list 'treesit--mode-associations (javascript-mode . js-ts-mode)) > > TBF one of my goals for the later patches was to avoid adding new public > "registry" variables, like treesit-auto-mode-alist, > treesit-major-mode-remap-alist, treesit-interpreter-mode-alist, etc. It In my mind, `treesit--mode-associations` is just a helper variable for the UI, to let modes register themselves as a possible good choice for specific languages, so the UI can provide nice defaults and/or completion. It should not change the behavior of Emacs in any significant way. >> and its name should not be treesitter-specific either, then. > ...But perhaps you have a more general purpose in mind for them. cperl-mode/perl-mode, latex-mode/LaTeX-mode, c-mode/sm-c-mode, caml-mode/tuareg-mode, ... >> We could also have a command `treesit-enable-all-modes` which uses >> a variable `treesit-mode-grammars` (an alist mapping modes to grammars, >> setup via the same kind of autoload+add-to-list as above), to add to >> `major-mode-remap-alist` all the TS modes for which the user has >> installed the corresponding grammar. > It seemed to me that users might first choose the modes/languages they want, > and then be told (sometimes with warnings) which grammars are still missing > or cannot be found by Emacs somehow. But there can be different ways of > looking at it. I'd imagine `treesit-enable-all-modes` could emit a warning about modes lacking a grammar when used interactively, and offer (maybe with a C-u prefix) to install the grammars? Stefan