From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: font-lock-comment-delimiter-face Date: Thu, 19 May 2005 10:44:27 -0400 Message-ID: References: <87wtq3ydmf.fsf-monnier+emacs@gnu.org> <17029.21411.495779.643570@farnswood.snap.net.nz> <17030.32533.416687.524645@farnswood.snap.net.nz> <85k6m04y6f.fsf@lola.goethe.zz> <857ji0nly2.fsf@lola.goethe.zz> <874qcz8jxd.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1116514537 27130 80.91.229.2 (19 May 2005 14:55:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 19 May 2005 14:55:37 +0000 (UTC) Cc: Edward O'Connor , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 19 16:55:23 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DYmNL-0007y4-Ed for ged-emacs-devel@m.gmane.org; Thu, 19 May 2005 16:51:52 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DYmPw-000808-Hl for ged-emacs-devel@m.gmane.org; Thu, 19 May 2005 10:54:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DYmLg-0005zA-Qd for emacs-devel@gnu.org; Thu, 19 May 2005 10:50:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DYmLd-0005xc-Qc for emacs-devel@gnu.org; Thu, 19 May 2005 10:50:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DYmLd-0005tn-3S for emacs-devel@gnu.org; Thu, 19 May 2005 10:50:05 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DYmOb-0003wF-Mn; Thu, 19 May 2005 10:53:09 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 116D12CF44F; Thu, 19 May 2005 10:44:36 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 494CD4AC016; Thu, 19 May 2005 10:44:27 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 327DB506F; Thu, 19 May 2005 10:44:27 -0400 (EDT) Original-To: rms@gnu.org In-Reply-To: <874qcz8jxd.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 19 May 2005 09:02:09 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-3.502, requis 5, AWL -1.28, BAYES_00 -4.90, SUBJ_HAS_UNIQ_ID 2.68) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37356 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37356 BTW, let me try to be constructive instead of just trying to shoot down the feature. How 'bout we change the current buggy code and replace it with something more general (and thus more useful to those people who aren't among the rare few who use 8 color ttys and whose red is not readable and who haven't already changed their font-lock colors): Introduce font-lock-comment-keywords which would basically work like font-lock-keywords, except it's applied only to comments (with the buffer narrowed to just the comment so that comment-start-skip matches correctly, without needing font-lock-comment-start-skip). This way we could highlight all nested comments in SML, or we could highlight the "*" used on some continuation lines in some multiline C commenting styles, and people could set it to nil if they don't care about the feature, and major modes could add stuff to it, e.g. to highlight javadoc directives, ... Stefan