From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Buffer menu fix Date: Wed, 07 Sep 2005 08:07:50 -0400 Message-ID: References: <87slwkfxt9.fsf@stupidchicken.com> <87slwjpug0.fsf@stupidchicken.com> <87wtlvrwet.fsf@stupidchicken.com> <878xyavuw2.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1126097015 28549 80.91.229.2 (7 Sep 2005 12:43:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 7 Sep 2005 12:43:35 +0000 (UTC) Cc: Chong Yidong , Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 07 14:43:33 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ECzGR-0005mh-Uz for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2005 14:42:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ECzKz-0005yF-JM for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2005 08:47:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ECyxv-0003SL-SX for emacs-devel@gnu.org; Wed, 07 Sep 2005 08:23:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ECyxt-0003R6-Hf for emacs-devel@gnu.org; Wed, 07 Sep 2005 08:23:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ECyxs-0003KX-Rg for emacs-devel@gnu.org; Wed, 07 Sep 2005 08:23:45 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ECymk-0005JW-Vb; Wed, 07 Sep 2005 08:12:15 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 7C9492CF5B4; Wed, 7 Sep 2005 08:07:54 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id D4A1A4AC00A; Wed, 7 Sep 2005 08:07:50 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id B1810E6BD3; Wed, 7 Sep 2005 08:07:50 -0400 (EDT) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Wed, 07 Sep 2005 01:01:37 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.846, requis 5, autolearn=not spam, AWL 0.05, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42703 Archived-At: > (defun Buffer-menu-make-sort-button (name column) > (if (equal column Buffer-menu-sort-column) (setq column nil)) > (let* ((downname (downcase name)) > ! (map (make-sparse-keymap))) > ;; This keymap handles both nil and non-nil > ;; values for Buffer-menu-use-header-line. > ! (define-key map [header-line mouse-1] 'Buffer-menu-sort-by-column) > ! (define-key map [header-line mouse-2] 'Buffer-menu-sort-by-column) > ! (define-key map [mouse-2] 'Buffer-menu-sort-by-column) > (define-key map [follow-link] 'mouse-face) > ! (define-key map "\C-m" 'Buffer-menu-sort-by-column) > (propertize name > + 'column column > 'help-echo (concat > (if Buffer-menu-use-header-line > "mouse-1, mouse-2: sort by " Then the keymap doesn't depend on `name' or `column', so it can be created once and for all at the toplevel, right? Stefan