unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [RFA] Console based mouse face highlighting.
Date: Thu, 17 May 2007 10:59:36 -0400	[thread overview]
Message-ID: <jwvtzubijkj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <17995.53754.860573.633945@kahikatea.snap.net.nz> (Nick Roberts's message of "Thu\, 17 May 2007 15\:54\:34 +1200")

>> > I can't easily add an extra argument to write_glyphs as it's called in many
>> > places.
>> 
>> But it sounds like all of them but one should be called with that
>> argument zero, so it shouldn't be too hard to convert them.  Am I
>> missing something?

> Well it means changes to write_glyphs and rif->write_glyphs in a dozen or so
> places in dispnew.c, and a change to x_write_glyph in xdisp.c at least (and
> perhaps w32con_write_glyphs).  If you're comfortable with those changes and
> still think it's the right approach, I'll do that.

It doesn't seem like it'd be a big problem as such.  But I do wonder why
this is necessary now, even though it hasn't been necessary until now for
all other places where we support mouse highlighting.  So a bit of
argumentation that explains why this situation is different seems in order.
It might also help understand the code, so I'd recommend to put it
in comments.


        Stefan

  reply	other threads:[~2007-05-17 14:59 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-12 10:02 [PATCH] Console based mouse face highlighting Nick Roberts
2007-05-12 10:11 ` Nick Roberts
2007-05-12 13:25 ` Eli Zaretskii
2007-05-12 23:54   ` Nick Roberts
2007-05-13  3:42     ` Eli Zaretskii
2007-05-13  4:19       ` Nick Roberts
2007-05-13  4:41         ` Eli Zaretskii
2007-05-14 21:11           ` Nick Roberts
2007-05-15  3:26             ` Eli Zaretskii
2007-05-15  3:53               ` Nick Roberts
2007-05-15 21:15                 ` Eli Zaretskii
2007-05-15 21:33                   ` David Kastrup
2007-05-16  3:16                     ` Eli Zaretskii
2007-05-15 22:39                   ` [PATCH/Now RFA] " Nick Roberts
2007-05-16  3:24                     ` Eli Zaretskii
2007-05-16  3:54                       ` Nick Roberts
2007-05-16 10:00                         ` [RFA] " Nick Roberts
2007-05-16 18:19                           ` Eli Zaretskii
2007-05-16 21:46                             ` Nick Roberts
2007-05-17  3:24                               ` Eli Zaretskii
2007-05-17  3:54                                 ` Nick Roberts
2007-05-17 14:59                                   ` Stefan Monnier [this message]
2007-05-17 20:29                                     ` Eli Zaretskii
2007-05-17 22:29                                     ` Nick Roberts
2007-05-17 20:14                                   ` Eli Zaretskii
2007-05-17 22:34                                     ` Nick Roberts
2007-05-18 14:33                                       ` Eli Zaretskii
2007-05-18 21:09                                         ` Nick Roberts
2007-05-19  7:25                                           ` Eli Zaretskii
2007-05-19  8:15                                             ` Nick Roberts
2007-05-19  8:46                                               ` Eli Zaretskii
2007-05-20  6:00                                                 ` Nick Roberts
2007-05-20  9:37                                                   ` Johan Bockgård
2007-05-20  9:51                                                     ` Nick Roberts
2007-05-22 15:54                                                       ` Johan Bockgård
2007-05-22 21:36                                                         ` Nick Roberts
2007-05-30  5:41                                                           ` Nick Roberts
2007-06-03  1:12                                                         ` Nick Roberts
2007-06-03 21:27                                                           ` Richard Stallman
2007-06-03 22:15                                                             ` Drew Adams
2007-06-03 23:31                                                             ` Nick Roberts
2007-06-04  3:24                                                               ` Eli Zaretskii
2007-05-20 18:54                                                   ` Eli Zaretskii
2007-05-20 20:12                                                     ` Renaming NEWS [was: [RFA] Console based mouse face highlighting.] Glenn Morris
2007-05-20 20:42                                                       ` Nick Roberts
2007-05-20 21:31                                                       ` Renaming NEWS Miles Bader
2007-05-21  8:09                                                         ` Glenn Morris
2007-05-21  8:42                                                           ` David Kastrup
2007-05-22  6:46                                                             ` Glenn Morris
2007-05-22  7:12                                                               ` Miles Bader
2007-05-22 17:08                                                                 ` Glenn Morris
2007-05-22  8:30                                                           ` Richard Stallman
2007-05-22 17:09                                                             ` Glenn Morris
2007-05-21 10:33                                                       ` Renaming NEWS [was: [RFA] Console based mouse face highlighting.] Richard Stallman
2007-05-19 22:31                                               ` [RFA] Console based mouse face highlighting Richard Stallman
2007-05-14 16:57     ` [PATCH] " Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtzubijkj.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).