From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: functionp bug Date: Wed, 09 Apr 2008 10:22:51 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207751020 11783 80.91.229.12 (9 Apr 2008 14:23:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Apr 2008 14:23:40 +0000 (UTC) Cc: Katsumi Yamaoka , ding@gnus.org, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 09 16:24:12 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JjbDR-0002X2-Lk for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2008 16:23:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JjbCn-00059v-Uv for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2008 10:23:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JjbCT-0004jK-Vj for emacs-devel@gnu.org; Wed, 09 Apr 2008 10:22:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JjbCS-0004gi-9E for emacs-devel@gnu.org; Wed, 09 Apr 2008 10:22:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JjbCS-0004gb-3x for emacs-devel@gnu.org; Wed, 09 Apr 2008 10:22:56 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JjbCN-0007vl-W6; Wed, 09 Apr 2008 10:22:52 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgoFAKpt/EfO+KV8/2dsb2JhbACBXKsZ X-IronPort-AV: E=Sophos;i="4.25,629,1199682000"; d="scan'208";a="18208114" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 09 Apr 2008 10:22:51 -0400 Original-Received: from pastel.home ([206.248.165.124]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id PSF42251; Wed, 09 Apr 2008 10:22:51 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 431718C24; Wed, 9 Apr 2008 10:22:51 -0400 (EDT) In-Reply-To: (Richard Stallman's message of "Wed, 09 Apr 2008 06:34:01 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94787 gmane.emacs.gnus.general:66743 Archived-At: > I think that change in functionp should be reverted. Any change in > such things tends to cause problems, so it is better to leave them alone > unless there is an important problem to be fixed. The old definition lead to bugs in *all* uses I've seen. All the uses I've seen fall in the following 2 categories: 1 - (if (functionp ) (funcall ...)) with the old definition, this signalled an error if was a special form. 2 - the kind of use that is discussed in this thread, where the code wants to check "can be the `car' of an valid Elisp expression", where using `functionp' made the test reject uses of `when' while it accepted uses of `if'. > Theoretical arguments trying to show that "this behavior couldn't > possibly be right for any caller" tend to be unreliable. Whatever > functionp does, code will have come to depend on it. Yes, the change is an incompatible one. But it will get rid of bugs. Stefan