* report-emacs-bug, flyspell
@ 2008-06-12 7:48 David Reitter
2008-06-13 15:15 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: David Reitter @ 2008-06-12 7:48 UTC (permalink / raw)
To: Emacs-Devel devel
When enabling flyspell in a buffer created by M-x report-emacs-bug, or
when flyspell is generally enabled for all text modes with (add-hook
'text-mode-hook 'flyspell-mode), an error from within post-command-
hook is thrown: `message-signature-separator' is void.
The reason for that is that `mail-mode-flyspell-verify' wrongly
assumes that `message-signature-separator' is defined. `report-emacs-
bug' enables mail mode, but does not load `message'.
A simple fix follows.
*** lisp/textmodes/flyspell.el 06 Apr 2008 12:51:35 +0100 1.118.2.6
--- lisp/textmodes/flyspell.el 12 Jun 2008 08:45:05 +0100
***************
*** 296,306 ****
"$")
nil t)
(point)))
! (signature-begin (save-excursion
! (goto-char (point-max))
! (re-search-backward message-signature-separator
! nil t)
! (point))))
(cond ((< (point) header-end)
(and (save-excursion (beginning-of-line)
(looking-at "^Subject:"))
--- 296,309 ----
"$")
nil t)
(point)))
! (signature-begin (if (not (boundp 'message-signature-separator))
! (point-max)
! (save-excursion
! (goto-char (point-max))
! (re-search-backward
! message-signature-separator
! nil t)
! (point)))))
(cond ((< (point) header-end)
(and (save-excursion (beginning-of-line)
(looking-at "^Subject:"))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: report-emacs-bug, flyspell
2008-06-12 7:48 report-emacs-bug, flyspell David Reitter
@ 2008-06-13 15:15 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2008-06-13 15:15 UTC (permalink / raw)
To: David Reitter; +Cc: Emacs-Devel devel
> When enabling flyspell in a buffer created by M-x report-emacs-bug, or when
> flyspell is generally enabled for all text modes with (add-hook
> text-mode-hook 'flyspell-mode), an error from within post-command-
> hook is thrown: `message-signature-separator' is void.
> The reason for that is that `mail-mode-flyspell-verify' wrongly assumes that
> message-signature-separator' is defined. `report-emacs-
> bug' enables mail mode, but does not load `message'.
> A simple fix follows.
Thanks, installed,
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-13 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-12 7:48 report-emacs-bug, flyspell David Reitter
2008-06-13 15:15 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).