unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Zero height line causing arithmetic errors
Date: Sat, 14 Jun 2008 13:35:30 -0400	[thread overview]
Message-ID: <jwvtzfwc4kq.fsf-monnier+emacs@gnu.org> (raw)


My MPC.el package uses an overlay placed at the end of a line with an
after-string of #("\n" 0 1 (face (:height 0.05 :inverse-video t)))
in order to place a horizontal line in the display.

In Emacs-22, this worked fine (except the line was a bit thicker than
0.05 times the base line height).  In Emacs-CVS until recently this
worked except that the line was full-height (i.e. 13 pixels in my case).
Recently, it has started to cause more problems because now
FRAME_SMALLEST_FONT_HEIGHT returns 0, and that value is used at 2 places
in the divisor position.

I guess the 0 is because 13 pixels (default font height) * 0.05 -> 0.65
pixels which are truncated to 0.

I currently use the patch below, which makes it all work again (tho
still with the problem that the 0.05 isn't taken into account and line
line is 13 pixel think), but I suspect it's not the right place to fix
it,


        Stefan


=== modified file 'src/font.c'
--- src/font.c	2008-06-13 16:25:44 +0000
+++ src/font.c	2008-06-14 17:30:14 +0000
@@ -2682,6 +2682,7 @@
       if (FRAME_SMALLEST_FONT_HEIGHT (f) > font->height)
 	FRAME_SMALLEST_FONT_HEIGHT (f) = font->height, fonts_changed_p = 1;
     }
+  FRAME_SMALLEST_FONT_HEIGHT (f) = max (1, FRAME_SMALLEST_FONT_HEIGHT (f));
 #endif
 
   return font_object;





             reply	other threads:[~2008-06-14 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-14 17:35 Stefan Monnier [this message]
2008-06-19  1:12 ` Zero height line causing arithmetic errors Kenichi Handa
2008-06-19  1:19   ` Dan Nicolaescu
2008-06-19 14:13   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtzfwc4kq.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).