unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: David Reitter <david.reitter@gmail.com>,
	Emacs-Devel devel <emacs-devel@gnu.org>,
	"Lennart Borgman \(gmail\)" <lennart.borgman@gmail.com>,
	Miles Bader <miles@gnu.org>
Subject: Re: visual-line-mode
Date: Fri, 11 Jul 2008 21:43:54 -0400	[thread overview]
Message-ID: <jwvtzevj2wm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87d4lknn4i.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 11 Jul 2008 17:10:05 -0400")

>> PS: My patch is just a proof of concept.  It has a few bugs.  One of
>> them can be seen when you set truncate-lines, in which case it doesn't
>> preserve columns correctly (basically, its temporary-goal-column ends
>> up being computed from the beginning of the displayed part of the line,
>> so as long as hscroll is not changed, it works OK but as soon as
>> hscroll is modified, the result is incorrect).

> Does the following patch give good results/make sense?

Not sure.  I'm not sure where is the bug, really.  If it's in
posn-point, or in vertical-motion, or simply in my Elisp code, or
a combination.  My gut feeling is that there's at least a bug in my
Elisp code and maybe also in the vertical-motion code (the part that
handles horizontal position, i.e. my new code there).

It looks like your patch presumes that the Elisp code is passing the
correct value, which I'm not sure is the case.  But it's probably going
in the right direction.


        Stefan




  reply	other threads:[~2008-07-12  1:43 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-29  6:30 visual-line-mode David Reitter
2008-06-29  7:05 ` visual-line-mode Miles Bader
2008-06-29  7:19   ` visual-line-mode Miles Bader
2008-06-29 14:01   ` visual-line-mode Stefan Monnier
2008-06-29 15:29     ` visual-line-mode Chong Yidong
2008-06-30  3:07     ` visual-line-mode Miles Bader
2008-06-30  3:15       ` visual-line-mode Chong Yidong
2008-06-30  5:13         ` visual-line-mode Miles Bader
2008-06-30  5:15           ` visual-line-mode Miles Bader
2008-06-30 10:39             ` visual-line-mode Miles Bader
2008-06-30 11:20               ` visual-line-mode Miles Bader
2008-06-30 14:01               ` visual-line-mode Chong Yidong
2008-06-30 16:10                 ` visual-line-mode Chong Yidong
2008-07-01  9:10               ` visual-line-mode David Reitter
2008-07-03 19:20           ` visual-line-mode Chong Yidong
2008-07-03 23:56             ` visual-line-mode David Reitter
2008-07-04 10:23               ` visual-line-mode Chong Yidong
2008-07-04 10:58                 ` visual-line-mode Miles Bader
2008-07-04 13:04                   ` visual-line-mode Chong Yidong
2008-07-04 15:04                     ` visual-line-mode David Reitter
2008-07-04 15:49                       ` visual-line-mode Stefan Monnier
2008-07-04 16:21                         ` visual-line-mode David Reitter
2008-07-05 18:41                       ` visual-line-mode Chong Yidong
2008-07-06  1:29                         ` visual-line-mode Miles Bader
2008-07-09 14:28                         ` visual-line-mode David Reitter
2008-07-10  3:05                           ` visual-line-mode Chong Yidong
2008-07-10 12:39                             ` visual-line-mode David Reitter
2008-07-10 13:55                               ` visual-line-mode Chong Yidong
2008-08-03 13:47                                 ` visual-line-mode David Reitter
2008-08-11 13:38                                   ` word-wrap in echo area (was Re: visual-line-mode) David Reitter
2008-08-11 16:03                                     ` word-wrap in echo area Chong Yidong
2008-07-10 16:37                               ` visual-line-mode Chong Yidong
2008-07-10 17:32                                 ` visual-line-mode Miles Bader
2008-07-10 17:40                                   ` visual-line-mode Miles Bader
2008-07-10 20:23                                   ` visual-line-mode Stefan Monnier
2008-07-10 23:23                                     ` visual-line-mode Chong Yidong
2008-07-10 23:44                                       ` visual-line-mode Miles Bader
2008-07-10 23:49                                         ` visual-line-mode Chong Yidong
2008-07-11 13:10                                         ` visual-line-mode David Reitter
2008-07-14  3:58                                           ` visual-line-mode Miles Bader
2008-07-14  3:59                                             ` visual-line-mode Miles Bader
2008-07-11  1:36                                       ` visual-line-mode Stefan Monnier
2008-07-11  2:30                                         ` visual-line-mode Miles Bader
2008-07-11  4:36                                         ` visual-line-mode Chong Yidong
2008-07-11 14:56                                           ` visual-line-mode David Reitter
2008-07-11 15:57                                             ` visual-line-mode Chong Yidong
2008-07-11 18:27                                               ` visual-line-mode Chong Yidong
2008-07-11 20:36                                             ` visual-line-mode Miles Bader
2008-07-11 21:18                                               ` visual-line-mode Stefan Monnier
2008-07-11 21:23                                                 ` visual-line-mode David Kastrup
2008-07-11 21:41                                                   ` visual-line-mode David Reitter
2008-07-12  1:49                                                   ` visual-line-mode Stefan Monnier
2008-07-12  8:09                                                     ` visual-line-mode David Kastrup
2008-07-12 16:35                                                       ` visual-line-mode Richard M Stallman
2008-07-12 17:42                                                         ` visual-line-mode Chong Yidong
2008-07-16  4:21                                                     ` visual-line-mode Chong Yidong
2008-07-16  4:37                                                       ` visual-line-mode Miles Bader
2008-07-11 21:10                                     ` visual-line-mode Chong Yidong
2008-07-12  1:43                                       ` Stefan Monnier [this message]
2008-07-10 18:08                                 ` visual-line-mode David Reitter
2008-07-10 23:18                                   ` visual-line-mode Miles Bader
2008-07-10 23:35                                     ` visual-line-mode Chong Yidong
2008-07-10 23:49                               ` visual-line-mode Chong Yidong
2008-07-09 14:31                         ` visual-line-mode David Reitter
2008-07-04 11:09                 ` visual-line-mode David Reitter
2008-07-04 12:39                   ` visual-line-mode Paul R
2008-06-30  7:32   ` visual-line-mode David Reitter
2008-06-30  7:43     ` visual-line-mode Miles Bader
2008-06-30  7:58       ` visual-line-mode David Reitter
2008-06-30  8:05         ` visual-line-mode Miles Bader
2008-06-30  8:25           ` visual-line-mode David Reitter
2008-06-30  8:30             ` visual-line-mode Miles Bader
2008-07-10  4:53 ` visual-line-mode Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtzevj2wm.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cyd@stupidchicken.com \
    --cc=david.reitter@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=lennart.borgman@gmail.com \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).