From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: 5x5 again Date: Tue, 24 May 2011 15:23:59 -0300 Message-ID: References: <80lixwr8hn.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306261452 1037 80.91.229.12 (24 May 2011 18:24:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 24 May 2011 18:24:12 +0000 (UTC) Cc: Jay P Belanger , emacs-devel@gnu.org To: Vincent =?iso-8859-1?Q?Bela=EFche?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 24 20:24:08 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QOwH1-0006Dg-Ud for ged-emacs-devel@m.gmane.org; Tue, 24 May 2011 20:24:08 +0200 Original-Received: from localhost ([::1]:33220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOwH1-00030j-A2 for ged-emacs-devel@m.gmane.org; Tue, 24 May 2011 14:24:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOwGz-00030O-AT for emacs-devel@gnu.org; Tue, 24 May 2011 14:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOwGx-00059I-0Y for emacs-devel@gnu.org; Tue, 24 May 2011 14:24:05 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:55423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOwGw-00059E-VE for emacs-devel@gnu.org; Tue, 24 May 2011 14:24:02 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:49386 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QOwGw-0001bD-Az; Tue, 24 May 2011 14:24:02 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A34C0662FB; Tue, 24 May 2011 15:23:59 -0300 (ART) In-Reply-To: <80lixwr8hn.fsf@gmail.com> ("Vincent =?iso-8859-1?Q?Bela=EFch?= =?iso-8859-1?Q?e=22's?= message of "Tue, 24 May 2011 07:08:20 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139683 Archived-At: > Here follows the Changelog and the patch. Sorry for the extra > disturbance. Installed, with the following nitpicks: > * play/5x5.el (5x5-new-game, 5x5-randomize): reset > 5x5-solver-output to nil when a new grid is cast. "reset" needs to be capitalized. > (5x5-log-init, 5x5-log): use defsubst instead of defmacro to shunt "use" needs to be capitalized. > these debugging traces, as defmacro breaks the compiled code. Note Two spaces after ".". > these logging facilities were not cleaned out as the aritmetic > solver is not yet complete --- it works only for grid size = 5. So > they may be useful again to design a more generic solution. I moved this into the code, where it belongs. Stefan