From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Vincent Belaïche" <vincent.b.1@hotmail.fr>
Cc: Jay P Belanger <jay.p.belanger@gmail.com>, emacs-devel@gnu.org
Subject: Re: 5x5 again
Date: Tue, 24 May 2011 15:23:59 -0300 [thread overview]
Message-ID: <jwvtyckdkm8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <80lixwr8hn.fsf@gmail.com> ("Vincent Belaïche"'s message of "Tue, 24 May 2011 07:08:20 +0200")
> Here follows the Changelog and the patch. Sorry for the extra
> disturbance.
Installed, with the following nitpicks:
> * play/5x5.el (5x5-new-game, 5x5-randomize): reset
> 5x5-solver-output to nil when a new grid is cast.
"reset" needs to be capitalized.
> (5x5-log-init, 5x5-log): use defsubst instead of defmacro to shunt
"use" needs to be capitalized.
> these debugging traces, as defmacro breaks the compiled code. Note
Two spaces after ".".
> these logging facilities were not cleaned out as the aritmetic
> solver is not yet complete --- it works only for grid size = 5. So
> they may be useful again to design a more generic solution.
I moved this into the code, where it belongs.
Stefan
next prev parent reply other threads:[~2011-05-24 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 5:08 5x5 again Vincent Belaïche
2011-05-24 18:23 ` Stefan Monnier [this message]
2011-05-25 6:13 ` Vincent Belaïche
2011-05-28 1:17 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2011-05-28 6:05 Vincent Belaïche
2011-05-30 13:40 ` Stefan Monnier
2011-05-31 19:52 Vincent Belaïche
2011-06-21 3:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtyckdkm8.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jay.p.belanger@gmail.com \
--cc=vincent.b.1@hotmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).