From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: Musings: Supposed places of safety, guaranteed by parse-partial-sexp are not safe.
Date: Sat, 03 Dec 2011 22:39:37 -0500 [thread overview]
Message-ID: <jwvty5h57rb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20111203232301.GD4566@acm.acm> (Alan Mackenzie's message of "Sat, 3 Dec 2011 23:23:01 +0000")
> There's a problem with parse-partial-sexp. If one scans to the middle
> of a comment opener /*
> ^
> |
> , parse-partial-sexp gives no indication that we might be half inside a
[...]
> No doubt there is some record of this state hidden away in (nth 9 state).
IIRC you're just a bit too optimistic: parse-partial-sexp does not
record this info anywhere. And yes, if my recollection is right, that
means it's got a bug.
The better way to fix it is probably to change the (nth 5 ppss) value so
it holds something like "buffer position actually described by PPSS in
case the requested buffer position is in the middle of a lexeme" and
so it can be used for both backslashes and multi-char comment markers.
Stefan
next prev parent reply other threads:[~2011-12-04 3:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 23:23 Musings: Supposed places of safety, guaranteed by parse-partial-sexp are not safe Alan Mackenzie
2011-12-03 23:40 ` Daniel Colascione
2011-12-04 3:39 ` Stefan Monnier [this message]
2011-12-04 10:41 ` martin rudalics
2011-12-04 15:21 ` Stefan Monnier
2011-12-04 17:06 ` martin rudalics
2011-12-04 20:47 ` Andreas Röhler
2011-12-05 3:33 ` Stefan Monnier
2011-12-05 7:41 ` martin rudalics
2011-12-05 14:01 ` Stefan Monnier
2011-12-05 11:35 ` Alan Mackenzie
2011-12-05 11:25 ` Alan Mackenzie
2011-12-06 10:15 ` martin rudalics
2011-12-06 10:33 ` Alan Mackenzie
2011-12-06 13:39 ` martin rudalics
2011-12-06 13:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvty5h57rb.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).