From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: /etc/TODO: define-minor-mode & minor-mode-list Date: Wed, 01 Feb 2012 09:06:46 -0500 Message-ID: References: <877h07fgua.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1328105228 28906 80.91.229.3 (1 Feb 2012 14:07:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 1 Feb 2012 14:07:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: William Stevenson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 01 15:07:08 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rsaq3-00044q-1Z for ged-emacs-devel@m.gmane.org; Wed, 01 Feb 2012 15:07:07 +0100 Original-Received: from localhost ([::1]:36296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rsapz-0000mr-Gm for ged-emacs-devel@m.gmane.org; Wed, 01 Feb 2012 09:07:03 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:56131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rsaps-0000l8-0d for emacs-devel@gnu.org; Wed, 01 Feb 2012 09:07:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rsapk-00069T-5s for emacs-devel@gnu.org; Wed, 01 Feb 2012 09:06:55 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:34212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rsapj-00069B-W0 for emacs-devel@gnu.org; Wed, 01 Feb 2012 09:06:48 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAP5FKU9MCqD0/2dsb2JhbABDrnqBBoFyAQEEAVYjBQsLDiYSFBgNJIgPuH2LXBICAgMGAgQCAQQCAgwGCgOEHgEEBB6DOQSIQZp6hFg X-IronPort-AV: E=Sophos;i="4.71,601,1320642000"; d="scan'208";a="160662104" Original-Received: from 76-10-160-244.dsl.teksavvy.com (HELO pastel.home) ([76.10.160.244]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 01 Feb 2012 09:06:46 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8D70559473; Wed, 1 Feb 2012 09:06:46 -0500 (EST) In-Reply-To: <877h07fgua.fsf@gmail.com> (William Stevenson's message of "Wed, 01 Feb 2012 02:05:49 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148085 Archived-At: > Also is this todo considered todone? Largely, yes. I did this during the Emacs-24 development (which lead to the addition of the `:variable' argument). My methodology to find potential minor modes was to grep for something like "defun.*-mode ([^)]" since traditionally minor modes take an argument, whereas major modes don't. There are a few cases I found which I haven't converted, usually because the conversion was less straightforward so I left it for later. These are: orgstruct++-mode, tcl-auto-fill-mode, vhdl-hs-minor-mode, speedbar-frame-mode, reftex-isearch-minor-mode, type-break-mode. There are probably other candidates, of course. As already mentioned, most/all "*-mode" functions should not be defined with `defun' but with one of define-*-mode. Stefan