From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: Romain Francoise <romain@orebokech.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] POSIX ACL support
Date: Mon, 19 Nov 2012 13:11:55 -0500 [thread overview]
Message-ID: <jwvtxsl1n47.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <h7gph34c5.fsf@fencepost.gnu.org>
>> The following patch adds support for preserving POSIX ACL entries of
>> files, which at the moment are lost when Emacs saves a buffer (unless
>> `backup-by-copying' is set).
> Thanks for writing this. It is definitely needed IMO.
>> -(defun backup-buffer-copy (from-name to-name modes context)
>> +(defun backup-buffer-copy (from-name to-name modes context acl)
> [and several other such]
> This is really a general comment, not an issue with your patch in
> particular, so don't let it distract. I just wonder if it is possible to
> find a different way to pass this information around, so that we don't
> need to have an ever increasing list of function arguments and return
> values (preserve-this, preserve-that, preserve-the-other, etc...).
> I don't have a good suggestion for how to do that.
> (I have a vague memory this was mentioned when SELinux was added.)
Yes, that's a problem. We should consolidate `modes', `context', and
`acl' into a `metadata' argument.
Stefan
next prev parent reply other threads:[~2012-11-19 18:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 22:27 [PATCH] POSIX ACL support Romain Francoise
2012-11-19 3:44 ` Eli Zaretskii
2012-11-19 21:41 ` Romain Francoise
2012-11-20 3:44 ` Eli Zaretskii
2012-11-19 17:11 ` Glenn Morris
2012-11-19 17:47 ` Eli Zaretskii
2012-11-19 18:11 ` Stefan Monnier [this message]
2012-11-19 21:33 ` Romain Francoise
2012-11-20 18:15 ` Stefan Monnier
2012-11-21 12:51 ` Romain Francoise
2012-11-21 14:25 ` Stefan Monnier
2012-11-21 15:36 ` Paul Eggert
2012-11-21 16:01 ` Romain Francoise
2012-11-21 18:17 ` Eli Zaretskii
2012-11-21 18:25 ` Paul Eggert
2012-11-21 19:09 ` Achim Gratz
2012-11-21 19:40 ` Eli Zaretskii
2012-11-21 19:52 ` Achim Gratz
2012-11-19 21:55 ` Paul Eggert
2012-11-20 18:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtxsl1n47.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).