From: Stefan <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r116779: Restore compatibility with legacy comment-start-skip values
Date: Mon, 17 Mar 2014 14:14:29 -0400 [thread overview]
Message-ID: <jwvtxaw4s3x.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <53271F7F.8070308@yandex.ru> (Dmitry Gutov's message of "Mon, 17 Mar 2014 18:14:55 +0200")
>>> + (save-excursion
>>> + (forward-char -1)
>>> + (looking-at comment-start-skip)))
>> This needs to additionally check that (match-end 1) points to what we
>> thought was the comment start.
> Can you think of a situation when that's not true?
"Think of", no. But I can make one up, if you want ;-)
BTW, the new code still will fail to match the ";hello" comment in
foo\\;hello
Maybe we should use narrow-to-region to get the ^ part of the regexp to
match at point.
> And suppose it doesn't, then what?
Admittedly, I'm not sure how to handle the more general case where
comment-start-skip uses sub-group 1 for something more significant than
to rule out an escape char.
Stefan
next prev parent reply other threads:[~2014-03-17 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WPRLY-0001sI-LW@vcs.savannah.gnu.org>
2014-03-17 15:50 ` [Emacs-diffs] trunk r116779: Restore compatibility with legacy comment-start-skip values Stefan
2014-03-17 16:14 ` Dmitry Gutov
2014-03-17 18:14 ` Stefan [this message]
2014-03-17 19:44 ` Dmitry Gutov
2014-03-17 23:32 ` Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtxaw4s3x.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).