unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Kim Storm <storm@cua.dk>
Cc: Chong Yidong <cyd@stupidchicken.com>, Emacs-devel@gnu.org
Subject: Re: The history of sit_for vs sit-for
Date: Fri, 30 May 2014 14:31:55 -0400	[thread overview]
Message-ID: <jwvtx87dsv0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5388C984.5010307@cua.dk> (Kim Storm's message of "Fri, 30 May 2014 20:10:12 +0200")

> It seems moving sit-for to lisp was the easiest way to accomplish that.

Indeed, thanks.

In any case, we have 2 problems with the current code:
- We have two completely different implementations: sit-for ELisp and
  sit_for in C.
- The ELisp version uses read-event and then tries to unread the event,
  which is frought with too many perils.

I don't really care whether sit-for is implemented in ELisp or C, but we
should only have one implementation (it's hard enough to get it to work
once).  And the implementation shouldn't read+unread.


        Stefan



      reply	other threads:[~2014-05-30 18:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 14:18 The history of sit_for vs sit-for Stefan Monnier
2014-05-29 20:19 ` Kim Storm
2014-05-30 15:32   ` Stefan Monnier
2014-05-30 18:10     ` Kim Storm
2014-05-30 18:31       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtx87dsv0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=Emacs-devel@gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).