From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 51e7e46: Font-lock elisp macros/special forms dynamically Date: Mon, 16 Mar 2015 13:31:48 -0400 Message-ID: References: <20150315082509.21193.18465@vcs.savannah.gnu.org> <55054CE9.6010702@dancol.org> <87bnjt4e00.fsf@gnu.org> <550681E3.7080407@dancol.org> <871tkpov7p.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426527135 12548 80.91.229.3 (16 Mar 2015 17:32:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Mar 2015 17:32:15 +0000 (UTC) Cc: Artur Malabarba , emacs-devel To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 16 18:32:07 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXYs1-0004pk-PT for ged-emacs-devel@m.gmane.org; Mon, 16 Mar 2015 18:32:05 +0100 Original-Received: from localhost ([::1]:50889 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXYs1-0005n0-8P for ged-emacs-devel@m.gmane.org; Mon, 16 Mar 2015 13:32:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXYrx-0005lM-GR for emacs-devel@gnu.org; Mon, 16 Mar 2015 13:32:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXYrr-0004VM-JD for emacs-devel@gnu.org; Mon, 16 Mar 2015 13:32:01 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXYrr-0004VD-EW for emacs-devel@gnu.org; Mon, 16 Mar 2015 13:31:55 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2GHVnnc000567; Mon, 16 Mar 2015 13:31:49 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id E412F6615C; Mon, 16 Mar 2015 13:31:48 -0400 (EDT) In-Reply-To: <871tkpov7p.fsf@gnu.org> (Tassilo Horn's message of "Mon, 16 Mar 2015 15:47:22 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5247=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5247> : inlines <2423> : streams <1406496> : uri <1881983> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183912 Archived-At: > using Daniel's suggestion. I like the "big optimized regexp" better than the "dynamic lookup via intern-soft" (should make for more efficient font-locking, tho I have no idea if that really proves faster in practice and even less of an idea if the difference would be measurable). Also, that loses the "update existing buffers after macro definition", so it's far from "clearly better" w.r.t end-user behavior (and the relative simplicity advantage will probably end up vanishing if we try to fill those kinds of differences). But it's largely a question of bikeshed color, so if you all prefer the intern-soft approach, go for it. > (2) adding (declare (no-font-lock-keyword t)) to all function-like > macros we have (e.g., push, pushnew) push and pushnew aren't function-like, so they *should* be highlighted as keywords, I think. Stefan