From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 51e7e46: Font-lock elisp macros/special forms dynamically Date: Wed, 18 Mar 2015 09:13:20 -0400 Message-ID: References: <20150315082509.21193.18465@vcs.savannah.gnu.org> <55054CE9.6010702@dancol.org> <87bnjt4e00.fsf@gnu.org> <550681E3.7080407@dancol.org> <871tkpov7p.fsf@gnu.org> <877fug8z8u.fsf@gnu.org> <55073F67.20809@dancol.org> <87k2yg55jl.fsf@gnu.org> <87sid2epuu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426684564 5794 80.91.229.3 (18 Mar 2015 13:16:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Mar 2015 13:16:04 +0000 (UTC) Cc: Artur Malabarba , emacs-devel To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 18 14:15:55 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYDpC-0003nH-NY for ged-emacs-devel@m.gmane.org; Wed, 18 Mar 2015 14:15:54 +0100 Original-Received: from localhost ([::1]:33510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDpB-0003Se-Rq for ged-emacs-devel@m.gmane.org; Wed, 18 Mar 2015 09:15:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDmq-00089J-NA for emacs-devel@gnu.org; Wed, 18 Mar 2015 09:13:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYDmm-0000Dh-DZ for emacs-devel@gnu.org; Wed, 18 Mar 2015 09:13:28 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:41651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDmm-0000DO-8D for emacs-devel@gnu.org; Wed, 18 Mar 2015 09:13:24 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2IDDKlS028912; Wed, 18 Mar 2015 09:13:20 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4370211C3; Wed, 18 Mar 2015 09:13:20 -0400 (EDT) In-Reply-To: <87sid2epuu.fsf@gnu.org> (Tassilo Horn's message of "Wed, 18 Mar 2015 08:17:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5249=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5249> : inlines <2432> : streams <1407501> : uri <1883714> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183992 Archived-At: > Ok. I just tried it anyway, and with jit-lock disabled, > `font-lock-flush' does nothing, e.g., the buffer portion you have I think you've just found a bug. How did you disable jit-lock? Can you try "emacs -Q --eval '(setq font-lock-support-mode nil)'" and retry your test. > If no one comes up with a (semi-)automated way of identifying > function-like macros, I'll go check the ~1300 macros in emacs manually. We could also do it lazily: wait for people to complain and fix those that come up. > + just there to save a funcall (ad-get-advice-info-macro, > shadow-cluster-name) > Shouldn't those be defsubsts instead of macros? Yes, but sometimes having them as macros is better (e.g., the code should be a bit faster than with a defsubst; also macros are expanded by gv.el so defining them as macros lets you use them as places in `setf' and `push' as well. The new `define-inline' does address both of those problems, OTOH). Stefan