From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Ken Brown <kbrown@cornell.edu>
Cc: "Michael R. Mauger" <michael@mauger.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 7466a4d: Cygwin emacsclient handles w32 file names
Date: Tue, 30 Jun 2015 09:56:44 -0400 [thread overview]
Message-ID: <jwvtwtppagc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5592018D.7070303@cornell.edu> (Ken Brown's message of "Mon, 29 Jun 2015 22:40:13 -0400")
>> + (when (and (eq system-type 'cygwin)
>> + (fboundp 'cygwin-convert-file-name-from-windows))
> There's no need for the 'fboundp ...' here;
> cygwin-convert-file-name-from-windows is defined in all Cygwin builds.
I'm not arguing for or against this test, but I'm just pointing out that
the test should have the benefit of silencing the byte-compiler when
compiling on a non-Cygwin machine.
Stefan
next prev parent reply other threads:[~2015-06-30 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150630005924.5663.80677@vcs.savannah.gnu.org>
[not found] ` <E1Z9jtU-0001Tx-85@vcs.savannah.gnu.org>
2015-06-30 2:40 ` [Emacs-diffs] master 7466a4d: Cygwin emacsclient handles w32 file names Ken Brown
2015-06-30 13:56 ` Stefan Monnier [this message]
2015-07-01 14:14 ` Ken Brown
2015-07-01 15:47 ` Eli Zaretskii
2015-07-02 2:28 ` Michael Mauger
2015-07-02 19:48 ` Ken Brown
2015-07-04 15:20 ` Ken Brown
2015-07-04 18:29 ` Stefan Monnier
2015-07-04 19:05 ` Ken Brown
2015-07-07 14:36 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtwtppagc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
--cc=michael@mauger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).