From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1b4442b: Don't expand body inside a let-binding when there are no bindings Date: Thu, 16 Feb 2017 08:32:06 -0500 Message-ID: References: <20170216014306.20854.5128@vcs0.savannah.gnu.org> <20170216014308.12DC326007@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487252074 3575 195.159.176.226 (16 Feb 2017 13:34:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Feb 2017 13:34:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 16 14:34:30 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceMCZ-0000Mm-01 for ged-emacs-devel@m.gmane.org; Thu, 16 Feb 2017 14:34:27 +0100 Original-Received: from localhost ([::1]:46668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceMCe-00021M-M3 for ged-emacs-devel@m.gmane.org; Thu, 16 Feb 2017 08:34:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceMAN-00087J-3b for emacs-devel@gnu.org; Thu, 16 Feb 2017 08:32:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceMAK-00086K-1k for emacs-devel@gnu.org; Thu, 16 Feb 2017 08:32:11 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:6008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ceMAJ-00085Q-Qq for emacs-devel@gnu.org; Thu, 16 Feb 2017 08:32:07 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DTBQADqaVY/56dpUVeGwEBAQMBAQEJAQEBg1GEdYtIkUcBlxUahgIEAgKCEkQUAQIBAQEBAQEBYiiEcQZWIxALNBIUGA2KI7JUizsBAQEBBgIBJYs7hSCFGQWQRIs7k3qITYZWkVWBQzYhgQAgFAgqPYR8gWYiimwBAQE X-IPAS-Result: A0DTBQADqaVY/56dpUVeGwEBAQMBAQEJAQEBg1GEdYtIkUcBlxUahgIEAgKCEkQUAQIBAQEBAQEBYiiEcQZWIxALNBIUGA2KI7JUizsBAQEBBgIBJYs7hSCFGQWQRIs7k3qITYZWkVWBQzYhgQAgFAgqPYR8gWYiimwBAQE X-IronPort-AV: E=Sophos;i="5.35,169,1484024400"; d="scan'208";a="293051901" Original-Received: from 69-165-157-158.dsl.teksavvy.com (HELO pastel.home) ([69.165.157.158]) by smtp.teksavvy.com with ESMTP; 16 Feb 2017 08:32:06 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 183B765017; Thu, 16 Feb 2017 08:32:06 -0500 (EST) In-Reply-To: <20170216014308.12DC326007@vcs0.savannah.gnu.org> (Mark Oteiza's message of "Wed, 15 Feb 2017 20:43:07 -0500 (EST)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212421 Archived-At: > + (if vars > + `(let ,(mapcar (lambda (b) (list (car b) (cdr b))) vars) > + ,@code) > + `(progn ,@code))) Just curious here: I resisted the temptation to do that when working on that code because I thought that it should (both in the sense that I expect the current code to behave that way, and in the sense that if it doesn't behave that way, we should fix it) make no difference to the byte-code we generate. So, I'm wondering if you've found a concrete case where it makes a difference, or it's just that you wanted the output to look more pretty. Stefan