From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ELPA Archive Build Fails Date: Mon, 11 Dec 2017 10:41:18 -0500 Message-ID: References: <87wp1u8c1z.fsf@gnu.org> <87r2s170oj.fsf@lifelogs.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513007002 29904 195.159.176.226 (11 Dec 2017 15:43:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Dec 2017 15:43:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 11 16:43:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQEd-0007WR-U1 for ged-emacs-devel@m.gmane.org; Mon, 11 Dec 2017 16:43:16 +0100 Original-Received: from localhost ([::1]:54097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOQEk-0004lX-QO for ged-emacs-devel@m.gmane.org; Mon, 11 Dec 2017 10:43:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOQCw-0003lG-On for emacs-devel@gnu.org; Mon, 11 Dec 2017 10:41:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOQCt-0007ka-K6 for emacs-devel@gnu.org; Mon, 11 Dec 2017 10:41:30 -0500 Original-Received: from [195.159.176.226] (port=59493 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOQCt-0007iS-Ds for emacs-devel@gnu.org; Mon, 11 Dec 2017 10:41:27 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eOQCj-0002qY-SR for emacs-devel@gnu.org; Mon, 11 Dec 2017 16:41:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 45 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:u4li7KNrMgnNBSVeF0QaC3qDqWU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220883 Archived-At: > Looking at that Make target: > check_copyrights: > @echo "Compute exceptions >$(CR_EXCEPTIONS)~" > @export LC_ALL=C; \ > (cd packages && \ > find . -name '.git' -prune -o \ > -name 'test' -prune -o \ > -name '*.el' -print0 | \ > xargs -0 grep -L 'Free Software Foundation, Inc' | \ > grep -v '\(\.dir-locals\|.-\(pkg\|autoloads\)\)\.el$$'; \ > find . -name '.git' -prune -o -name '*.el' -type f -print | \ > while read f; do \ > fquoted="$$(echo $$f|tr '|' '_')"; \ > sed -n -e '/[Cc]opyright.*, *[1-9][-0-9]*,\?$$/N' \ > -e '/Free Software Foundation/d' \ > -e "s|^\\(.*[Cc]opyright\\)|$$fquoted:\\1|p" \ > "$$f"; \ > done) | sort >$(CR_EXCEPTIONS)~ > diff -u "$(CR_EXCEPTIONS)" "$(CR_EXCEPTIONS)~" > > I can sort of understand the shell logic, but not why it's there. > Could someone (Stefan?) please either add comments to the GNUMakefile > explaining what it does and why, or explain here and I'll add the > comments? It does a very crude check to try and catch the files which lack the "copyright FSF" line (that's the role of the first `find`), and to catch the files which still have a "copyright " somewhere. I think in the present case the "right fix" is to update the $(CR_EXCEPTIONS) file. > Ideally the output of the check would also be improved to explain what's > wrong. I can try to do that as well. Yes. I think it's OK that the test is crude: the purpose is not to perform a thorough check but to catch the obvious mistakes which are very frequent (i.e. the rule rather than the exception) in new packages/files). But the output would benefit from being more user-friendly. Stefan