From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode Date: Sat, 27 Oct 2018 20:30:24 -0400 Message-ID: References: <20181017063829.3775.67018@vcs0.savannah.gnu.org> <20181017063831.03DCB2044D@vcs0.savannah.gnu.org> <810f1e04-1117-476d-9a7d-d57002609bf8@default> <5BCC3743.8040103@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540686518 24562 195.159.176.226 (28 Oct 2018 00:28:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2018 00:28:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: martin rudalics , emacs-devel@gnu.org To: Federico Tedin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 28 02:28:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGYwT-0006He-L8 for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2018 02:28:33 +0200 Original-Received: from localhost ([::1]:38259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGYya-0003Of-3Z for ged-emacs-devel@m.gmane.org; Sat, 27 Oct 2018 20:30:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGYyU-0003OP-Hp for emacs-devel@gnu.org; Sat, 27 Oct 2018 20:30:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGYyR-0006Lo-79 for emacs-devel@gnu.org; Sat, 27 Oct 2018 20:30:38 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGYyQ-0006I0-MP for emacs-devel@gnu.org; Sat, 27 Oct 2018 20:30:35 -0400 Original-Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w9S0UO5B005976; Sat, 27 Oct 2018 20:30:24 -0400 Original-Received: by lechazo.home (Postfix, from userid 20848) id 6F8B760248; Sat, 27 Oct 2018 20:30:24 -0400 (EDT) In-Reply-To: (Federico Tedin's message of "Fri, 26 Oct 2018 19:07:31 -0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6405=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6405> : inlines <6947> : streams <1802570> : uri <2739364> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230744 Archived-At: > By implementing `reactivate-mark-function` alone, the problem of not > knowing the region type would still remain. If we store the region > type instead, then the value could be read directly, and > `reactivate-mark` could be implemented as: > > (defun reactivate-mark () > (pcase region-type > ('normal ...) > ('rectangle ...) > ...)) We don't want the code to list the finite set of known region types, I think. We could try and make it a cl-defgeneric, but we need something on which to dispatch. Stefan