From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs master build failing on RHEL 6.8 Date: Tue, 07 May 2019 11:30:45 -0400 Message-ID: References: <834l66jpty.fsf@gnu.org> <831s1ajo0w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177237"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 17:33:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO25h-000juu-IR for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 17:33:13 +0200 Original-Received: from localhost ([127.0.0.1]:48698 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO25g-0004Zp-Ha for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 11:33:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO23Y-0002eO-Cm for emacs-devel@gnu.org; Tue, 07 May 2019 11:31:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO23X-0004Z6-JI for emacs-devel@gnu.org; Tue, 07 May 2019 11:31:00 -0400 Original-Received: from [195.159.176.226] (port=42452 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hO23X-0004YO-Cf for emacs-devel@gnu.org; Tue, 07 May 2019 11:30:59 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hO23P-000gvH-H1 for emacs-devel@gnu.org; Tue, 07 May 2019 17:30:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:WMIrVj66Gp5huYqaBjo4cVAEyy0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236235 Archived-At: > Does it help to flush the # characters all the way to the left, and Indeed, I'm surprised by: #if GNUC_PREREQ (4, 6, 0) #pragma GCC diagnostic push #endif #if LIBRSVG_CHECK_VERSION (2, 45, 1) && GNUC_PREREQ (4, 2, 0) #pragma GCC diagnostic ignored "-Wdeprecated-declarations" #endif I always thought that the `#` at to be in column-0, hence the indentation convention of: #if foo # define BAR toto #endif But since this is coming from Paul, I assume he knows that it's allowed to have spaces before the `#` (at least in recent enough versions of C?). Stefan