unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Emacs master build failing on RHEL 6.8
Date: Tue, 07 May 2019 11:30:45 -0400	[thread overview]
Message-ID: <jwvtve6e12c.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 831s1ajo0w.fsf@gnu.org

> Does it help to flush the # characters all the way to the left, and

Indeed, I'm surprised by:

  #if GNUC_PREREQ (4, 6, 0)
   #pragma GCC diagnostic push
  #endif
  #if LIBRSVG_CHECK_VERSION (2, 45, 1) && GNUC_PREREQ (4, 2, 0)
   #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
  #endif

I always thought that the `#` at to be in column-0, hence the
indentation convention of:

    #if foo
    #  define BAR toto
    #endif

But since this is coming from Paul, I assume he knows that it's allowed
to have spaces before the `#` (at least in recent enough versions of C?).


        Stefan




  reply	other threads:[~2019-05-07 15:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 12:00 Emacs master build failing on RHEL 6.8 Kaushal Modi
2019-05-07 14:34 ` Eli Zaretskii
2019-05-07 14:41   ` Kaushal Modi
2019-05-07 15:13     ` Eli Zaretskii
2019-05-07 15:30       ` Stefan Monnier [this message]
2019-05-07 15:52         ` Eli Zaretskii
2019-05-07 16:01           ` Kaushal Modi
2019-05-07 18:22             ` Eli Zaretskii
2019-05-07 19:46               ` Kaushal Modi
2019-05-08  5:47                 ` Eli Zaretskii
2019-05-08  8:03                   ` Andreas Schwab
2019-05-08 11:42                   ` Kaushal Modi
2019-05-08 12:27                     ` Eli Zaretskii
2019-05-08 12:49                       ` Kaushal Modi
2019-05-08 13:05                         ` Eli Zaretskii
2019-05-08 15:07                           ` Kaushal Modi
2019-05-08 15:41                             ` Paul Eggert
2019-05-08 15:50                               ` Kaushal Modi
2020-02-14 19:49                                 ` WilliamKF
2020-02-14 20:44                                   ` Paul Eggert
2019-05-07 18:49         ` Mattias Engdegård
2019-05-08 15:57           ` Paul Eggert
2019-05-08 17:16             ` CPP indentation bikeshed (was: Emacs master build failing on RHEL 6.8) Stefan Monnier
2019-05-09  4:25               ` Paul Eggert
2019-05-07 17:37 ` Emacs master build failing on RHEL 6.8 martin rudalics
2019-05-07 18:20   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtve6e12c.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).