* Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet
[not found] ` <20190617102239.7C2C120B45@vcs0.savannah.gnu.org>
@ 2019-06-17 12:18 ` Stefan Monnier
2019-06-17 12:25 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2019-06-17 12:18 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Hi Lars,
> + ;; The `classpath' slot only exists in the Java parts of cedet, and
> + ;; those have not been merged into Emacs. Suppress the warning
> + ;; about the unknown slot by using `intern'.
> + (slot-value (ede-config-get-configuration proj)
> + (intern "classpath" obarray)))
There should be a better way to silence this kind of warning, no?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet
2019-06-17 12:18 ` [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet Stefan Monnier
@ 2019-06-17 12:25 ` Lars Ingebrigtsen
2019-06-17 13:26 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-17 12:25 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Hi Lars,
>
>> + ;; The `classpath' slot only exists in the Java parts of cedet, and
>> + ;; those have not been merged into Emacs. Suppress the warning
>> + ;; about the unknown slot by using `intern'.
>> + (slot-value (ede-config-get-configuration proj)
>> + (intern "classpath" obarray)))
>
> There should be a better way to silence this kind of warning, no?
Indeed. I wondered about adding a `slot' thing to
`with-suppressed-warnings', but (as discussed elsewhere in that big
thread), that bit isn't in effect when the CLOS machinery is doing its
thing...
If that can be fixed, I can rewrite these instances in cedet.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet
2019-06-17 12:25 ` Lars Ingebrigtsen
@ 2019-06-17 13:26 ` Stefan Monnier
2019-06-17 13:52 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2019-06-17 13:26 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
>>> + (slot-value (ede-config-get-configuration proj)
>>> + (intern "classpath" obarray)))
>>
>> There should be a better way to silence this kind of warning, no?
>
> Indeed. I wondered about adding a `slot' thing to
> `with-suppressed-warnings', but (as discussed elsewhere in that big
> thread), that bit isn't in effect when the CLOS machinery is doing its
> thing...
Maybe just a `(eieio-declare-slots FOO BAR...)` at top-level?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-17 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190617102236.20294.96863@vcs0.savannah.gnu.org>
[not found] ` <20190617102239.7C2C120B45@vcs0.savannah.gnu.org>
2019-06-17 12:18 ` [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet Stefan Monnier
2019-06-17 12:25 ` Lars Ingebrigtsen
2019-06-17 13:26 ` Stefan Monnier
2019-06-17 13:52 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).