Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet

Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet

[Stefan Monnier]

Hi Lars,

> +  ;; The `classpath' slot only exists in the Java parts of cedet, and
> +  ;; those have not been merged into Emacs.  Suppress the warning
> +  ;; about the unknown slot by using `intern'.
> +  (slot-value (ede-config-get-configuration proj)
> +              (intern "classpath" obarray)))

There should be a better way to silence this kind of warning, no?


        Stefan

Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hi Lars,
>
>> +  ;; The `classpath' slot only exists in the Java parts of cedet, and
>> +  ;; those have not been merged into Emacs.  Suppress the warning
>> +  ;; about the unknown slot by using `intern'.
>> +  (slot-value (ede-config-get-configuration proj)
>> +              (intern "classpath" obarray)))
>
> There should be a better way to silence this kind of warning, no?

Indeed.  I wondered about adding a `slot' thing to
`with-suppressed-warnings', but (as discussed elsewhere in that big
thread), that bit isn't in effect when the CLOS machinery is doing its
thing...

If that can be fixed, I can rewrite these instances in cedet.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet

[Stefan Monnier]

>>> +  (slot-value (ede-config-get-configuration proj)
>>> +              (intern "classpath" obarray)))
>>
>> There should be a better way to silence this kind of warning, no?
>
> Indeed.  I wondered about adding a `slot' thing to
> `with-suppressed-warnings', but (as discussed elsewhere in that big
> thread), that bit isn't in effect when the CLOS machinery is doing its
> thing...

Maybe just a `(eieio-declare-slots FOO BAR...)` at top-level?


        Stefan

Re: [Emacs-diffs] master 5e63ea1 5/6: Suppress warning about out-of-tree Java class in cedet

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> (eieio-declare-slots FOO BAR...)

Good idea.  I've now done this.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no