From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049. Date: Thu, 14 Nov 2019 10:33:25 -0500 Message-ID: References: <20191109144026.20810.76129@vcs0.savannah.gnu.org> <20191109144027.DDC3720927@vcs0.savannah.gnu.org> <38328d99-23c8-7ba7-a23d-e70ac0aab67a@yandex.ru> <20191111203445.GA5135@ACM> <7497e71d-bab6-fa04-bbc4-f52fadeda16d@yandex.ru> <20191113211936.GB4942@ACM> <6fc930a1-eb47-9e54-8752-8cf7ff041586@yandex.ru> <03042d05-2160-77c4-9abd-b0f13f638247@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="267119"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alan Mackenzie , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 16:33:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVH7w-0017MJ-RC for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 16:33:44 +0100 Original-Received: from localhost ([::1]:58772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVH7v-0000do-Dd for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 10:33:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33618) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVH7m-0000dG-Ak for emacs-devel@gnu.org; Thu, 14 Nov 2019 10:33:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVH7k-0002Ea-Jc for emacs-devel@gnu.org; Thu, 14 Nov 2019 10:33:33 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39898) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iVH7k-0002EP-Cb for emacs-devel@gnu.org; Thu, 14 Nov 2019 10:33:32 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7193B449CD0; Thu, 14 Nov 2019 10:33:31 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 22FB3449CCE; Thu, 14 Nov 2019 10:33:30 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1573745610; bh=dZfzJiOsdUI5ZL3LPBRAnfrk7L/tIyvuuG4BrTLZOjY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=offyarbtu3fE/93c4itYpqzyCge1mosq4drzNkBYQOik57S296TeZhIsXq+NXwlNY bNv7uo1DjrCXzD40HB67HWb230XZ+2plOMuiRblZy0TOxbHwSUVk8jTDsvxJWbHhzd MAil6ur35jO5XGBnDrKGrye+ZQWqP1UtJuHTwAudpzsZs09hw9EGzUYugmpIWOsfyM Mal2LoGBLE9S9qwit5ZSktzbkx2ULltdNSxQi+eAGYHOHwWzvA9hpTYP+kCUBx6kUz 2BVH+RA3twEhUxDXTLPgbM8pg8/WmV3hAP6r9gL3TEMXobI0iMgExzdB7D/NCmRZ33 cCpQm1jrX+W4Q== Original-Received: from pastel (206-248-133-142.dsl.teksavvy.com [206.248.133.142]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E0EAF1201BB; Thu, 14 Nov 2019 10:33:29 -0500 (EST) In-Reply-To: (Dmitry Gutov's message of "Thu, 14 Nov 2019 17:02:36 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242183 Archived-At: >>> diff --git a/lisp/reposition.el b/lisp/reposition.el >>> index 22f9986efb..5d9c3180ad 100644 >>> --- a/lisp/reposition.el >>> +++ b/lisp/reposition.el >>> @@ -174,8 +174,8 @@ reposition-window >>> (defun repos-count-screen-lines (start end) >>> (save-excursion >>> (save-restriction >>> - (narrow-to-region start end) >>> - (goto-char (point-min)) >>> + (narrow-to-region (point-min) end) >>> + (goto-char start) >>> (vertical-motion (- (point-max) (point-min)))))) >> This looks like a good change in any case, tho it does beg the question: >> why does it narrow? > > I think it does that simply because vertical-motion takes LINES as an > argument, and not LIMIT. And it's easier to narrow the buffer than > compute the number of lines between start and end. Ah, right, that makes total sense. So, a big +1 on this patch from me. >> So, your earlier patch which added a call to `font-lock-ensure` was >> "more or less right", except that it should have used >> `jit-lock-ensure` (currently called `jit-lock-fontify-now`) > But wouldn't this fail to work when jit-lock is not used? I don't think so, no: it will (should) just do nothing. But in case it misbehaves, I'd consider it a bug in jit-lock.el. > And we'll need a guard to make sure font-lock is used as well. (*) Why would we need that? Stefan