unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ikumi Keita <ikumi@ikumi.que.jp>
Cc: emacs-devel@gnu.org
Subject: Re: Giving "text quotes" syntax in font-lock-syntax-table only
Date: Thu, 04 Jun 2020 10:00:58 -0400	[thread overview]
Message-ID: <jwvtuzrvsoo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <32983.1591277792@localhost> (Ikumi Keita's message of "Thu, 04 Jun 2020 22:36:32 +0900")

>> Could you test the patch below to see if it makes the old code
>> work correctly?
> Yes, the fontification doesn't get scrambled with this modification.

Thanks.  I pushed it to `master`.

> If I understand correctly, fontification still can fail even with this
> fix, if `font-lock-syntax-table' is modified after font lock mode is
> enabled.

Yes, if `font-lock-syntax-table` is modified/set directly rather than
via the 4th element of `font-lock-defaults`.

> So I think it's preferable to advertise that `font-lock-syntax-table'
> should not modified directly, unless the modification is restricted
> within translation between ".",  "w" and "_", once after font lock
> mode is enabled.

We should probably deprecate the use of `font-lock-syntax-table`, indeed.


        Stefan




      reply	other threads:[~2020-06-04 14:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  6:53 Giving "text quotes" syntax in font-lock-syntax-table only Ikumi Keita
2020-05-20 11:53 ` Stefan Monnier
2020-05-20 13:24   ` Ikumi Keita
2020-05-22  8:37     ` Ikumi Keita
2020-06-02 18:46     ` Stefan Monnier
2020-06-03  8:12       ` Ikumi Keita
2020-06-03 14:12   ` Stefan Monnier
2020-06-04 13:36     ` Ikumi Keita
2020-06-04 14:00       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtuzrvsoo.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=ikumi@ikumi.que.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).