From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Thomas Fitzsimmons <fitzsim@fitzsim.org>, emacs-devel@gnu.org
Subject: Re: master 9f464cc: Stop using calc for ntlm time computation
Date: Tue, 27 Oct 2020 09:45:19 -0400 [thread overview]
Message-ID: <jwvtuuflr73.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwva6w7n7jd.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 27 Oct 2020 09:06:43 -0400")
> Didn't get there yet. Here's my latest attempt:
OK, I found another problem in the way I was running the tests, so
I think I finally did manage to run them correctly, which indeed finds
a real problem:
% make EMACS="/usr/bin/emacs" EMACS_EXTRAOPT="-l /u/monnier/src/emacs/trunk/lisp/net/ntlm.el" MODULES_EMACSOPT="" test/lisp/net/ntlm-tests
make -C test lisp/net/ntlm-tests
make[1] : on entre dans le répertoire « /home/monnier/src/emacs/trunk/test »
make[2] : on entre dans le répertoire « /home/monnier/src/emacs/trunk/test »
GEN lisp/net/ntlm-tests.log
Running 1 tests (2020-10-27 09:42:55-0400)
Test ntlm-time-to-timestamp backtrace:
signal(wrong-type-argument (integerp 1.1644473632001902e+17))
apply(signal (wrong-type-argument (integerp 1.1644473632001902e+17))
(setq value-2 (apply fn-0 args-1))
(unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-descri
(if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de
(let (form-description-4) (if (unwind-protect (setq value-2 (apply f
(let ((value-2 (quote ert-form-evaluation-aborted-3))) (let (form-de
(let* ((fn-0 (function equal)) (args-1 (condition-case err (let ((si
(let ((time (quote (24471 63910 412962 0)))) (let* ((fn-0 (function
(closure (t) nil (let ((time (quote (24471 63910 412962 0)))) (let*
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name ntlm-time-to-timestamp :documentation
ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit (quote (not (tag :unstable)))))
command-line-1(("-L" ":." "-l" "/u/monnier/src/emacs/trunk/lisp/net/
command-line()
normal-top-level()
Test ntlm-time-to-timestamp condition:
(wrong-type-argument integerp 1.1644473632001902e+17)
FAILED 1/1 ntlm-time-to-timestamp
Ran 1 tests, 0 results as expected, 1 unexpected (2020-10-27 09:42:55-0400)
1 unexpected results:
FAILED ntlm-time-to-timestamp
The problem is that in `ntlm-tests--time-to-timestamp`, the constant
116444736000000000 is too large.
Stefan
next prev parent reply other threads:[~2020-10-27 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200816091703.7193.11125@vcs0.savannah.gnu.org>
[not found] ` <20200816091705.318C0209AC@vcs0.savannah.gnu.org>
2020-10-26 21:19 ` master 9f464cc: Stop using calc for ntlm time computation Thomas Fitzsimmons
2020-10-26 21:57 ` Mattias Engdegård
2020-10-27 11:33 ` Mattias Engdegård
2020-10-27 13:06 ` Stefan Monnier
2020-10-27 13:45 ` Stefan Monnier [this message]
2020-10-27 14:01 ` Mattias Engdegård
2020-10-27 14:06 ` Mattias Engdegård
2020-10-27 15:23 ` Stefan Monnier
2020-10-27 16:18 ` Mattias Engdegård
2020-10-27 16:28 ` Thomas Fitzsimmons
2020-10-27 13:53 ` Mattias Engdegård
2020-10-27 15:34 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtuuflr73.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=fitzsim@fitzsim.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).