From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 527413f: Go back to not using custom-push-theme when enabling a theme Date: Fri, 06 Nov 2020 10:04:30 -0500 Message-ID: References: <20201106123610.24601.8123@vcs0.savannah.gnu.org> <20201106123612.2172F20B2C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36538"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mauro Aranda Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 16:06:01 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kb3JQ-0009Ot-Fw for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 16:06:00 +0100 Original-Received: from localhost ([::1]:46280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb3JP-0001Yp-FU for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 10:05:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb3I4-0008WA-J5 for emacs-devel@gnu.org; Fri, 06 Nov 2020 10:04:36 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb3I2-0000jH-5D for emacs-devel@gnu.org; Fri, 06 Nov 2020 10:04:35 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 17193440BA3; Fri, 6 Nov 2020 10:04:33 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C6E154407F9; Fri, 6 Nov 2020 10:04:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604675071; bh=EeeSMAv8B8156gM0LDgZGMFZEY/9sLOg75ZM4UtZ+5E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gBUPKjiazRgSxQl/eUaVm6xHdp7M/2p2xg4syLtmMI40Vm640RkaDM3KZ2bxHA6fO vq3OLp72XguCdU+Az8lfjnbyFvTCRHSdCy6aDwt88FrtPfSQP3FbFhftHMzsiVZdTu DuHPZu//V7aYlQp8oZtkZFLWzVwJ3HVpdEbaBVWPDggYbDUA/VsVYRtQiwrBLlHdBj bGx17Aw+izZTuEo5NJw3baEZ+wvEfh9gbBKwPO/7LQazXp/u/TnqqaYHd01TaFdMIT sL0dXrju3Z7sbQ1pwyolQ0+v8/R4Ct+wlIvAU/mx2rXSu1RZ9PSJbIymGTEv7IXsDr pZ+toWmtUoRWw== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 95F001201E6; Fri, 6 Nov 2020 10:04:31 -0500 (EST) In-Reply-To: <20201106123612.2172F20B2C@vcs0.savannah.gnu.org> (Mauro Aranda's message of "Fri, 6 Nov 2020 07:36:11 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 08:56:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258824 Archived-At: > Go back to not using custom-push-theme when enabling a theme > > * lisp/custom.el (enable-theme): Relying on custom-push-theme to > handle theme settings and prior user settings was a mistake. The > theme settings haven't changed between loading the theme and enabling > it, so we don't need all of what custom-push-theme does. However, we > still need to save a user setting outside of Customize, in order to be > able to get back to it, so do that in enable-theme itself. Hi, could you explain what's the motivation behind this change? Is it an optimization (i.e. with hopefully no visible effect), or does it fix an actual problem? If it fixes an actual problem, could you try and add a corresponding regression test for it? Stefan