From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: gnus-article-view-part no longer seems to work (since commit 041b3904?) Date: Sun, 07 Feb 2021 11:05:38 -0500 Message-ID: References: <87k0rlmm1d.fsf@ucl.ac.uk> <87czxc8528.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26901"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, ding@gnus.org, Eric S Fraga To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 07 17:06:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8mZp-0006p0-Eh for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Feb 2021 17:06:21 +0100 Original-Received: from localhost ([::1]:48254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8mZo-0005DR-HW for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Feb 2021 11:06:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8mZF-0004ma-3I for emacs-devel@gnu.org; Sun, 07 Feb 2021 11:05:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8mZB-0002pX-9L for emacs-devel@gnu.org; Sun, 07 Feb 2021 11:05:44 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5A43C100222; Sun, 7 Feb 2021 11:05:40 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EA66E10005D; Sun, 7 Feb 2021 11:05:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612713938; bh=ESOpTiR+JjUH54ndL21VCOvhSC6QRrGegmsQ/EIl4V4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eBefR1Owq3EBZnlNktjHXC4h+dNL0nXSe29gwEkSzgrEHF/TaZMNEyAbYtJOiXBon sK2DkoddWLitQiaXTIeP8U+ilfQrOtOcsM3kvE9wA8YS0icM/ynuPU8RkEOxM0n0Sy l9agWsU0xOqPbXYKA8xdUw5vGqgiMwKEMM92mxwluryicXTfnn6qoEvmyzdWD4Llo1 14f08vntiqvveVKsM1olr8d+PGUWLLV2vHtIqqNeH5fLlDG/xMOUucoAnKekcJgwz3 IxFN8mB+lMxDEMC/p9q/8CtRpRzzNXWeVDcOXOMe2QaGYCVpVskXmzbp0RLz/miGtp 9giE0OlFpJc9w== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AFF2F12029C; Sun, 7 Feb 2021 11:05:38 -0500 (EST) In-Reply-To: <87czxc8528.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 07 Feb 2021 12:56:15 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264122 gmane.emacs.gnus.general:89914 Archived-At: >> longer behaves as it used to. In particular, invoking >> gnus-article-view-part (typically by hitting "b" but I've tried the >> other bindings just in case) in the summary buffer does not change the >> view of the article as it used to (for articles that had, say, text and >> HTML parts). > > This comes from this patch: > > commit e1e9e4eefa41bacb6b412e57a569440a0847e4fa > Author: Stefan Monnier > AuthorDate: Fri Jan 29 23:58:58 2021 -0500 > > * lisp/gnus/gnus-art.el: Add `event` args and operate at its position. > > In particular, it's this bit: > > (defun gnus-article-press-button (&optional event) > "Check text at point for a callback function. > If the text at point has a `gnus-callback' property, > call it with the value of the `gnus-data' text property." > (interactive (list last-nonmenu-event)) > (save-excursion > (mouse-set-point event) > > `mouse-set-point' here changes the buffer to the summary buffer. I'm > not quite sure what the rationale here is... and there's no mouse > involved... > > Stefan? Hmm... indeed in the OP's case the function is not called interactively, but via some other function (`gnus-article-view-part`) which changes buffer. We could change the caller to provide some dummy `event` but it's easier to just replace the (mouse-set-point event) with (if event (mouse-set-point event)) -- Stefan