From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Wed, 03 Mar 2021 17:15:59 -0500 Message-ID: References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14065"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 23:19:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHZpb-0003WU-58 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 23:18:59 +0100 Original-Received: from localhost ([::1]:41466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHZpa-0005OW-5R for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 17:18:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHZmp-0002As-V2 for emacs-devel@gnu.org; Wed, 03 Mar 2021 17:16:09 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHZml-0001b9-Oi for emacs-devel@gnu.org; Wed, 03 Mar 2021 17:16:07 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 15FB8441DFD; Wed, 3 Mar 2021 17:16:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9596F441DF1; Wed, 3 Mar 2021 17:16:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614809760; bh=edLOt0ev6t2LMPXbLQtaEJnBC+LKW2Z7XG8PUVXTbN8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=paHT4oCl+CMnEfGMSWv78ZlNjVgY/0oZuZGrukXsnhoEQqzLHVqT7KRcYzeKW88DQ X502ETppzKeovCcMN4C9JloO4ZesquKhMKfFhtPcZ78Xx5CeonBl6ygyV2Jfo2CeXc SO4LXFgUclxkqedKOPxqpUoSRXhomujNILHnIe/EdGdVLb+ZLQRz//JYUSVnyoL7Kq dlc5cNqPUR4z16q1XU0JxljLWCpCYIP7Xnh+usaq/RtsSqtI1kLOUXPidU+hCA9BiD 4S4qcJngF6ErwINhA/bsve5TP2VKQkuvnBB4eMkohOslGOcJVmEx+Fu3YUMjuHh6kY UqguPE4bJel9g== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9677C1202ED; Wed, 3 Mar 2021 17:16:00 -0500 (EST) In-Reply-To: <87h7lsthzh.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 03 Mar 2021 14:44:02 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265920 Archived-At: >> Fix misuses of `byte-compile-macro-environment` > > This seems to result in the following test failure with 'make check', > but strangely not with 'make test/pcase-tests': Hmm... I wonder why the test code worked before that patch. The problem is that pcase macros defined with `pcase-defmacro` can't be used in the same file where they're defined (you need to wrap them in `eval-and-compile`). Maybe we should fix that, but the problem is not new, so I'm wondering why the bug didn't trigger earlier. > BTW, 'make bootstrap' now emits this warning: > > In cl--sm-macroexpand: > emacs-lisp/cl-macs.el:2301:61: Warning: Unused lexical argument `dontcare' Yes, that's good: the warning wanrs about an actual problem. > (The 'sm' is the artist's signature, right? ;) Nah, the artist found a good excuse: "s(ymbol-)m(acrolet)" > Is this the right fix? Yes, but it doesn't just pacify the byte-compiler: it fixes the source code (in Emacs-27, this worked by accident, really). Stefan