unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "T.V Raman" <raman@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: define-minor-mode: Suppressing warning
Date: Sun, 16 May 2021 17:41:08 -0400	[thread overview]
Message-ID: <jwvtun2tlep.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <p91im3izcae.fsf@google.com> (T. V. Raman's message of "Sun, 16 May 2021 12:52:41 -0700")

> Really? I looked at define-minor-mode in emacs 27.1 and it does not
> appear to take the keyword argument, unless that is I'm very confused.

The Emacs-21 version of the docstring says (among other things):

    The above three arguments can be skipped if keyword arguments are
    used (see below).
    
    BODY contains code that will be executed each time the mode is (dis)activated.
      It will be executed after any toggling but before running the hooks.
      BODY can start with a list of CL-style keys specifying additional arguments.
      The following keyword arguments are supported:
    :group   Followed by the group name to use for any generated `defcustom'.
    :global  If non-nil specifies that the minor mode is not meant to be
             buffer-local.  By default, the variable is made buffer-local.
    :init-value  Same as the INIT-VALUE argument.
    :lighter  Same as the LIGHTER argument.

The end of the docstring on Emacs-24 additionally says:

    For example, you could write
      (define-minor-mode foo-mode "If enabled, foo on you!"
        :lighter " Foo" :require 'foo :global t :group 'hassle :version "27.5"
        ...BODY CODE...)

Do you believe me now?  ;-)


        Stefan


>> T.V Raman [2021-05-16 09:44:54] wrote:
>>
>>> When compiling code released for emacs 27.2 with emacs 28, you
>>> presently get this warning:
>>>
>>> emacspeak-comint.el:582:12: Warning: Use keywords rather than deprecated
>>> positional arguments to `define-minor-mode'
>>>
>>> I'm unable to suppress this warning  --- and I cant update my code
>>>    to use the recommended keyword argument form until emacs 28 is
>>>    released.
>>
>> Why?  The recommended syntax is the one that was introduced back in
>> Emacs-21!
>>
>>
>>         Stefan
>>




  reply	other threads:[~2021-05-16 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 16:44 define-minor-mode: Suppressing warning T.V Raman
2021-05-16 17:00 ` Stefan Monnier
2021-05-16 19:52   ` T.V Raman
2021-05-16 21:41     ` Stefan Monnier [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-05-16 20:04 T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtun2tlep.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).