From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Wed, 02 Jun 2021 09:38:06 -0400 Message-ID: References: <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <871r9laj6a.fsf@gmail.com> <1a183c3b.2f2f.179cb27f64c.Coremail.tumashu@163.com> <87lf7s7lli.fsf@gmail.com> <2dd59f1c-1d4d-a7d7-fae5-d9ca9b5c90c2@yandex.ru> <8e0cfb49-4ce3-c9aa-21fd-f0063b7c8107@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22043"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dmitry Gutov , tumashu , Daniel Mendler , Juri Linkov , "emacs-devel@gnu.org" To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 15:39:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loR5w-0005Z4-1i for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 15:39:40 +0200 Original-Received: from localhost ([::1]:50624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loR5u-00059j-VS for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 09:39:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loR4Y-0002P2-Ix for emacs-devel@gnu.org; Wed, 02 Jun 2021 09:38:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loR4U-0001b3-LL for emacs-devel@gnu.org; Wed, 02 Jun 2021 09:38:13 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0CAA910028A; Wed, 2 Jun 2021 09:38:09 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6F57C1001FB; Wed, 2 Jun 2021 09:38:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622641087; bh=T6i4OrH+Mc6bxblXnjv33oouWb//SZ3yP61Y1AhYlG4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kB9wVYQIKHpzDbL5ZWJaBsBafxOrGsY6V2IQBTn+ayz41036QOPSawud/qgL74ZYA KZ3J8ern70XSsSkx3ZTuhBIuenBi7l5+MbMLJ7VCmlZF8ICuwktGFpNbGeYvTCEqnu qHuNJdmyGiSbWsRLomw3g7gy1gru4C6eSq3ez1FEz0CpTz6outuK5BlB7OZBrV068A 1s5FYm2303Vp3gmddnzdcuBV1LQmau5G7rEIxY5syU24EfyBazExnEdeyqt6XHujMj FqqFxPaNW+oY8U8a1WsP6T/vpTs3sNdxpVbp8dx5yLizYGZxPBoJ2j+MmO8O2R06m9 AF/fdqFVco6Nw== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1BAE712033B; Wed, 2 Jun 2021 09:38:07 -0400 (EDT) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Wed, 2 Jun 2021 12:33:48 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270288 Archived-At: > Indeed it doesn't, just tried it. So I have even less objection to doing it. > Do you have a take on the reasons for this `icomplete-tidy` call in > pre-command-hook? I think it was/is the fear that the overlay could interfere with the command. AFAIK it was written under the assumption that the `icomplete-tidy` call would be automatically "undone" by the `post-command-hook` before the next redisplay. Stefan