unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 8761d30: Avoid failing if vc backend doesn't implement ignore-completion-table
       [not found] ` <20210831213707.51319209C6@vcs0.savannah.gnu.org>
@ 2021-08-31 21:51   ` Stefan Monnier
  2021-08-31 22:16     ` Dmitry Gutov
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2021-08-31 21:51 UTC (permalink / raw)
  To: emacs-devel; +Cc: Philip Kaludercic

> -         (vc-call-backend backend 'ignore-completion-table root))))
> +         (condition-case nil
> +             (vc-call-backend backend 'ignore-completion-table root)
> +           (vc-not-supported () nil)))))

The usual way to do that is to

   (defun vc-default-ignore-completion-table (...) nil)


-- Stefan


PS: WIBNI VC used cl-generic?




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 8761d30: Avoid failing if vc backend doesn't implement ignore-completion-table
  2021-08-31 21:51   ` master 8761d30: Avoid failing if vc backend doesn't implement ignore-completion-table Stefan Monnier
@ 2021-08-31 22:16     ` Dmitry Gutov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Gutov @ 2021-08-31 22:16 UTC (permalink / raw)
  To: Stefan Monnier, emacs-devel; +Cc: Philip Kaludercic

On 01.09.2021 00:51, Stefan Monnier wrote:
>> -         (vc-call-backend backend 'ignore-completion-table root))))
>> +         (condition-case nil
>> +             (vc-call-backend backend 'ignore-completion-table root)
>> +           (vc-not-supported () nil)))))
> The usual way to do that is to
> 
>     (defun vc-default-ignore-completion-table (...) nil)

Yep. That's a really good idea actually.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-31 22:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210831213706.27697.90002@vcs0.savannah.gnu.org>
     [not found] ` <20210831213707.51319209C6@vcs0.savannah.gnu.org>
2021-08-31 21:51   ` master 8761d30: Avoid failing if vc backend doesn't implement ignore-completion-table Stefan Monnier
2021-08-31 22:16     ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).