From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Mattias Engdegård" <mattiase@acm.org>, emacs-devel@gnu.org
Subject: Re: master 3ed79cd: Separate bytecode stack
Date: Tue, 15 Mar 2022 15:29:45 -0400 [thread overview]
Message-ID: <jwvtubzaub9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83k0cvi8g6.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Mar 2022 16:42:01 +0200")
Eli Zaretskii [2022-03-15 16:42:01] wrote:
>> From: Mattias Engdegård <mattiase@acm.org>
>> Date: Tue, 15 Mar 2022 15:20:29 +0100
>> Cc: Emacs-Devel <emacs-devel@gnu.org>
>>
>> >> The latter alternative would become a little more palatable if we could use flexible array struct members on all platforms. Given that we assume C99, can we do that now?
>> >
>> > What do you mean by "flexible array struct members"? Please show a
>> > code snippet.
>>
>> I'm sure you know it well, it's the ability to put an incomplete array
>> declaration as the last member of a struct, as in:
>>
>> struct S { int n; float a[]; };
>>
>> which roughly means the same thing as declaring that array to be of size zero.
>> It's not required in our case but would make the next_stack function (see patch) go away.
>
> I think you can use this (we already use it elsewhere in Emacs).
AFAICT we usually use:
struct Lisp_Vector
{
union vectorlike_header header;
Lisp_Object contents[FLEXIBLE_ARRAY_MEMBER];
} GCALIGNED_STRUCT;
but I suspect that by now we don't need this compatibility hack.
Stefan
prev parent reply other threads:[~2022-03-15 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 17:39 master 3ed79cd: Separate bytecode stack Eli Zaretskii
2022-03-13 18:44 ` Mattias Engdegård
2022-03-13 18:50 ` Eli Zaretskii
2022-03-14 15:56 ` Mattias Engdegård
2022-03-14 17:15 ` Eli Zaretskii
2022-03-15 14:20 ` Mattias Engdegård
2022-03-15 14:42 ` Eli Zaretskii
2022-03-15 15:08 ` Robert Pluim
2022-03-15 19:29 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtubzaub9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).