From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 18ec3fcce9: Restore pending_signals at a point in the DND event loop Date: Wed, 20 Apr 2022 11:05:26 -0400 Message-ID: References: <165015596397.5558.5393619769224500857@vcs2.savannah.gnu.org> <20220417003924.49D86C01684@vcs2.savannah.gnu.org> <87sfqcnz2s.fsf@yahoo.com> <87lew4ntlf.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40724"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 20 17:21:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhC8a-000ALk-S6 for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 17:21:01 +0200 Original-Received: from localhost ([::1]:35780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhC8Z-0005xt-Mf for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 11:20:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhBtm-0004Lz-Jl for emacs-devel@gnu.org; Wed, 20 Apr 2022 11:05:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhBtj-0004P4-WE for emacs-devel@gnu.org; Wed, 20 Apr 2022 11:05:41 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2670E80675; Wed, 20 Apr 2022 11:05:38 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E08748056D; Wed, 20 Apr 2022 11:05:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1650467136; bh=0Ez3W8c1S7dhmY755/9KPKDgZyd3KK+quuDDo6iSh74=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=m8hm4tE4h59u+yJFL8SMwITVws02ES4PNJA7ZE5ThyZvUNcZSIL6EQ+CS5P0pFgi0 xArgfDWTSdFu6oUfJo8xXKA776fKvQ6SvPbOWhWn1i4avwVyku+6yhP18+5Q2FAK6V YJV2r5OkPCHdEEQazk0lKvmsHsfwy+OtqzKdHwbkBD4D/Ga9scQnztOsDMDbi0ORKl +AyzNVWLtjAExq5G+IIM5NHM4KmgJbs/Txzoq2eomqP6xdCYIOSETgnuE5xl8+XOhb SuVnKS7VQtHtuZB17gnRV/3S5o3SXiN4lyzdmbTTHrgTC9TCVG5IyIsC4EoMXEbdgf VC8XJcOs/kvUA== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B3BE212037B; Wed, 20 Apr 2022 11:05:36 -0400 (EDT) In-Reply-To: <87lew4ntlf.fsf@yahoo.com> (Po Lu's message of "Sun, 17 Apr 2022 13:53:48 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288714 Archived-At: > Changing `process_pending_signals' to take into account a small > technicality in the X11 drag-and-drop code seems much less clean to me > than three lines of code accompanied by an explaining comment. To me, those 3 lines are impenetrable. So, if you could explain (or show) what it would take to do it more like what I suggest, maybe I can at least improve the comment. Stefan