From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Testing font things Date: Tue, 29 Nov 2022 22:31:26 -0500 Message-ID: References: <83tu2s2y70.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32911"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 30 04:32:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0DpN-0008Kv-J2 for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Nov 2022 04:32:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0Doz-0003fT-C1; Tue, 29 Nov 2022 22:31:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0Dox-0003dj-7J for emacs-devel@gnu.org; Tue, 29 Nov 2022 22:31:39 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0Dou-0003W8-7M; Tue, 29 Nov 2022 22:31:37 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 527AB44251F; Tue, 29 Nov 2022 22:31:33 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7186B44251A; Tue, 29 Nov 2022 22:31:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1669779087; bh=OF1krkRQbhT6ZWxqAATbvAaqdSHsbYg85yeOCP3zw0M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=da7rlurGeAnf5BKmuwJYxXJmhn9dEhcwsca5TRRpa1JvQVUU2WJJmTrNEqjwovZE6 JqvciI5/U+Ss2jvmc+FuE9HTOhZmZbzD4F/+ECWTQKUkOBLkvo0vGT2G5Rs947lU4e R8NhR5swAo3/W8p7o5fmuP7thXAcSAIjDbJgsyisG//mbBKGyVWZ4APPSaK3VOMIGR eypt4djzXSmQqpFCoIi5vghADlO8dapcOYZGsNx2LLsNfT2JFKbr2jbYo37LNM6PCk eh3h+gWy6b52glJLc4GKSysYb8cafnnX71u2j0KafWgXi5vaAC1qElegkePlZDDXk9 a/a2a3P6MjpMA== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4918C12088D; Tue, 29 Nov 2022 22:31:27 -0500 (EST) In-Reply-To: <83tu2s2y70.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Nov 2022 16:12:51 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300747 Archived-At: >> I'm trying to write a test for our font choice code (bug#59347) > Is it useful? We've had a fair bit of regressions in our font-selection code over the years, and some of those have happened several times, so I think it would be useful, yes. > This test will work only on your platform and maybe on a few > other lucky ones. Sounds like a good reason to add more tests to cover other cases. [ FWIW, Dejavu Sans is very widespread under GNU/Linux, AFAIK, and misc-fixed used to be very widespread as well, so there's a chance I'm not the only one where this test can run. ] > I suggest to defer coding of the test until we fully understand the > problem, and then try to write the test in some generic way > independent of specific font families. Writing tests for the font code is not super easy, so I'd rather we get started earlier than wait for some hypothetical future. It's much easier to improve/extend existing tests than trying to figure out how the hell can we test GUI code in batch mode. > ...why do you need to go to these obscure entities, when you have the font's > name as a string to begin with? So you should be able to: > > . use face-font, which returns the font's name as a string I'm not sure `face-font` will faithfully reproduce the result I'll see on my screen. > . compare that string with what you wanted it to be I'd rather not hard code any specific font name, actually, which is why my code was written to just check that we get one of the available fonts from the "DejaVu Sans" family. > . and/or use find-font to check whether the font is in fact installed on > the system How does that compare to `list-fonts`? Stefan