From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: autorevert.el Date: 03 Mar 2004 08:24:58 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200403022319.i22NJbG01259@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1078441972 1200 80.91.224.253 (4 Mar 2004 23:12:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 Mar 2004 23:12:52 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Mar 05 00:12:46 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Az21F-0003cI-00 for ; Fri, 05 Mar 2004 00:12:45 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Az21F-0004Lk-00 for ; Fri, 05 Mar 2004 00:12:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1Az207-0000Ye-6a for emacs-devel@quimby.gnus.org; Thu, 04 Mar 2004 18:11:35 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1AyWXj-0007Id-Jv for emacs-devel@gnu.org; Wed, 03 Mar 2004 08:36:11 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1AyWN6-0004uR-Ks for emacs-devel@gnu.org; Wed, 03 Mar 2004 08:25:44 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.30) id 1AyWN5-0004uK-O8 for emacs-devel@gnu.org; Wed, 03 Mar 2004 08:25:11 -0500 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 0E36420A0D; Wed, 3 Mar 2004 08:24:59 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id D27DB8C8E4; Wed, 3 Mar 2004 08:24:58 -0500 (EST) Original-To: Luc Teirlinck In-Reply-To: <200403022319.i22NJbG01259@raven.dms.auburn.edu> Original-Lines: 16 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.428, requis 5, BAYES_20 -1.43) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20242 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20242 > Any objections to me applying the patch below? I have been using it > without any problems for two weeks now. Most of the patch looks right (the list-diff thing was just horrendous and showed a serious misunderstanding), except I'd try to merge a bit more the dired and non-dired checks since both check the modtime. As for the auto-revert-flag thingy, I find it truly ugly because I don't like dired knowing about auto-revert just for the sake of verbosity control. There's got to be a better way. Also, I'd use file-remote-p rather than (string-match "@"), especially since remote files might not include any @. Stefan