From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: next-error-last-buffer Date: 28 May 2004 11:29:00 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <871xluig40.fsf@mail.jurta.org> <87u0y6jjq9.fsf@mail.jurta.org> <87n03wgt76.fsf@mail.jurta.org> <4nd64rl2ah.fsf@lifelogs.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1085765184 2313 80.91.224.253 (28 May 2004 17:26:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 28 May 2004 17:26:24 +0000 (UTC) Cc: Ted Zlatanov , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri May 28 19:26:14 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BTl7V-0000aj-00 for ; Fri, 28 May 2004 19:26:13 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BTl7V-00050s-00 for ; Fri, 28 May 2004 19:26:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BTki5-0001dD-3n for emacs-devel@quimby.gnus.org; Fri, 28 May 2004 12:59:57 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BTkhC-0001cH-Ig for emacs-devel@gnu.org; Fri, 28 May 2004 12:59:02 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BTkgf-0001X8-5s for emacs-devel@gnu.org; Fri, 28 May 2004 12:59:00 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BTjIL-0004ul-CK; Fri, 28 May 2004 11:29:17 -0400 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 02A30B302C4; Fri, 28 May 2004 11:29:01 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id CE7CE8CA23; Fri, 28 May 2004 11:29:00 -0400 (EDT) Original-To: rms@gnu.org In-Reply-To: Original-Lines: 27 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=0, requis 5) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24088 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24088 > Maybe if there's more than one next-error capable buffers that are > linked together (e.g. occur on a diff) then C-u next-error should > advance through the "underlying" next-error buffer (the diff) while > next-error should advance through the "overlay" next-error buffer > (the occur). > That is a bad solution because it requires people to remember > yet another feature. The other solution is better, because > it is more likely that the intended thing will happen > as a result of use of the other existing features. A less intrusive (and hence less complete) solution: - Create a new compilation-last-source-buffer variable. - At the end of next-error, set this new variable to the buffer just being displayed. - at the beginning of next-error check compilation-last-source-buffer: if it is equal to current-buffer, then don't consider this buffer as a "compilation" buffer (i.e. ignore its next-error-function). This way if a C-x ` lands us in a diff-mode buffer (because of a *grep* that points to a patch file), a subsequent C-x ` in the same buffer will not mistakenly step through the diffs of this buffer but will go to the next grep match. Stefan