unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: A new(?) warning of erase-buffer, which was not seen before.
Date: Fri, 23 Mar 2007 12:54:57 -0400	[thread overview]
Message-ID: <jwvslbvq4tg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <yoijwt18qfst.fsf@gamma02.me.chalmers.se> ("Johan Bockgård"'s message of "Fri\, 23 Mar 2007 13\:56\:34 +0100")

>>>> I've been working on some patches to comint to do this, by selectively
>>>> disabling undo at various points, but it's not entirely straight-forward
>>>> because you then have to fix up the undo list to account for the
>>>> unrecorded buffer changes.
>>> 
>>> FWIW, erc.el does this kind of selective undo.
>> 
>> How does it deal with changing buffer locations?

> Nicely.

>> My attempted solution was to scan through buffer-undo-list, updating
>> those position, every time I inserted some "hidden from undo" text.
>> [This isn't typically a performance problem because _usually_
>> buffer-undo-list is nil when process output is occuring.]

> That's exactly what ERC does.  See erc-update-undo-list.

I.e. we should probably add a "insert-without-undo" function which does
just that.


        Stefan

  reply	other threads:[~2007-03-23 16:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-19  2:20 A new(?) warning of erase-buffer, which was not seen before ishikawa
2007-03-19 12:19 ` Kim F. Storm
2007-03-20  3:48   ` ishikawa
2007-03-20  9:42     ` Kim F. Storm
2007-03-22 11:08       ` ishikawa
2007-03-22 22:50         ` Richard Stallman
2007-03-22 23:21           ` Miles Bader
2007-03-23  9:47             ` ishikawa
2007-03-23 14:52               ` Davis Herring
2007-03-23  9:54             ` Johan Bockgård
2007-03-23 11:31               ` Miles Bader
2007-03-23 12:56                 ` Johan Bockgård
2007-03-23 16:54                   ` Stefan Monnier [this message]
2007-03-23 17:01                     ` Lennart Borgman (gmail)
2007-03-23 17:35                       ` martin rudalics
2007-03-24  2:41                         ` Miles Bader
2007-03-24  9:09                           ` martin rudalics
2007-03-19 18:10 ` Richard Stallman
2007-03-20  3:52   ` ishikawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvslbvq4tg.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).