From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Stephen.Berman@gmx.net: Re: redisplay] Date: Wed, 25 Apr 2007 15:34:30 -0400 Message-ID: References: <87mz0z5dux.fsf@stupidchicken.com> <462D059B.7020001@swipnet.se> <462F1593.6030601@swipnet.se> <462F6ABA.6030808@swipnet.se> <462F9E30.4000702@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1177529823 12902 80.91.229.12 (25 Apr 2007 19:37:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 25 Apr 2007 19:37:03 +0000 (UTC) Cc: Glenn Morris , Chong Yidong , rms@gnu.org, emacs-devel@gnu.org To: Jan =?iso-8859-1?Q?Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 25 21:36:57 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HgnIN-0004V4-Gp for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2007 21:36:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HgnO1-0004mC-RS for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2007 15:42:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HgnLs-0002wt-FP for emacs-devel@gnu.org; Wed, 25 Apr 2007 15:40:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HgnLr-0002wV-Lk for emacs-devel@gnu.org; Wed, 25 Apr 2007 15:40:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HgnLr-0002wP-G3 for emacs-devel@gnu.org; Wed, 25 Apr 2007 15:40:31 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HgnG9-0006hM-Vd; Wed, 25 Apr 2007 15:34:38 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 21D6D2CF417; Wed, 25 Apr 2007 15:34:37 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 1FDFA3FE1; Wed, 25 Apr 2007 15:34:31 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 06BA56C80A; Wed, 25 Apr 2007 15:34:30 -0400 (EDT) In-Reply-To: <462F9E30.4000702@swipnet.se> (Jan =?iso-8859-1?Q?Dj=E4rv's?= message of "Wed\, 25 Apr 2007 20\:30\:08 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.94 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70123 Archived-At: > After some experimenting it seems that this patch fixes it. Note that > a call to redisplay() does not fix the bug. I don't know why. But a full > redisplay before every dialog maybe is too much? Am I wrong in thinking that Fredisplay(Qt) does not redraw every single frame, but just does a normal redisplay (i.e. update the out-of-date elements of the display), with the exception that it will complete the redisplay even if there's input pending? I.e. if the display is already up-to-date, Fredisplay(Qt) is a no-op? If so, and it works, then your patch looks fine to me. Stefan > diff -w -c src/xmenu.c.~1.317.~ src/xmenu.c > Index: src/xmenu.c > *** src/xmenu.c.~1.317.~ 2007-01-21 11:33:57.000000000 +0100 > --- src/xmenu.c 2007-04-25 20:27:02.000000000 +0200 > *************** > *** 3333,3338 **** > --- 3333,3340 ---- > /* No selection has been chosen yet. */ > menu_item_selection = 0; > + Fredisplay (Qt); > + > /* Actually create and show the dialog. */ > create_and_show_dialog (f, first_wv); > Jan D. > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel