From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Console based mouse face highlighting. Date: Mon, 14 May 2007 12:57:17 -0400 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1179161872 17813 80.91.229.12 (14 May 2007 16:57:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 14 May 2007 16:57:52 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 14 18:57:50 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hndro-0004Ib-P5 for ged-emacs-devel@m.gmane.org; Mon, 14 May 2007 18:57:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hndza-000614-MH for ged-emacs-devel@m.gmane.org; Mon, 14 May 2007 13:05:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HndzC-0005rW-7D for emacs-devel@gnu.org; Mon, 14 May 2007 13:05:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HndzA-0005qp-Qn for emacs-devel@gnu.org; Mon, 14 May 2007 13:05:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HndzA-0005qi-G9 for emacs-devel@gnu.org; Mon, 14 May 2007 13:05:24 -0400 Original-Received: from tomts20.bellnexxia.net ([209.226.175.74] helo=tomts20-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HndrM-00056I-LI; Mon, 14 May 2007 12:57:20 -0400 Original-Received: from pastel.home ([70.55.144.218]) by tomts20-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070514165718.GXP1637.tomts20-srv.bellnexxia.net@pastel.home>; Mon, 14 May 2007 12:57:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id EF5888042; Mon, 14 May 2007 12:57:17 -0400 (EDT) In-Reply-To: <17990.21422.577087.305723@kahikatea.snap.net.nz> (Nick Roberts's message of "Sun\, 13 May 2007 11\:54\:22 +1200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71046 Archived-At: > 1) Does write_glyphs *overwrite* existing glyphs (while insert_glyphs adds > to them) ? It would be nice if a comment said what these functions do. Please, as soon as you understand enough about this code, add a comment explaining what you understood. > 2) After a call to write_glyphs, does the cursor position move? Add a note about that as well. Stefan "more and more convinced that commenting is the role of the person browsing/using/rereading the code"