From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: new frame-parameter "alpha" Date: Sat, 15 Mar 2008 17:19:37 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205615995 14835 80.91.229.12 (15 Mar 2008 21:19:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Mar 2008 21:19:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Seiji Zenitani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 15 22:20:24 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jadni-000601-Bb for ged-emacs-devel@m.gmane.org; Sat, 15 Mar 2008 22:20:22 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jadn8-0000Zz-Jl for ged-emacs-devel@m.gmane.org; Sat, 15 Mar 2008 17:19:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jadn3-0000Vp-SJ for emacs-devel@gnu.org; Sat, 15 Mar 2008 17:19:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jadn2-0000RJ-0R for emacs-devel@gnu.org; Sat, 15 Mar 2008 17:19:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jadn1-0000R1-Se for emacs-devel@gnu.org; Sat, 15 Mar 2008 17:19:39 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jadn1-0001sN-LX for emacs-devel@gnu.org; Sat, 15 Mar 2008 17:19:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAObZ20dMCraG/2dsb2JhbACnUYEK X-IronPort-AV: E=Sophos;i="4.25,506,1199682000"; d="scan'208";a="16098385" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 15 Mar 2008 17:19:37 -0400 Original-Received: from pastel.home ([76.10.182.134]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id VYI32837; Sat, 15 Mar 2008 17:19:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2F86E8F77; Sat, 15 Mar 2008 17:19:37 -0400 (EDT) In-Reply-To: (Seiji Zenitani's message of "Sat, 15 Mar 2008 15:54:43 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92700 Archived-At: Looks good. Tho maybe I'd put the call to x_set_frame_alpha directly inside x_update_cursor (and rename it to x_update_cursor_and_opacity). I don't mind the use of "alpha" rather than "opacity", as long as the docstrings are clear. The patch needs to also update the manual. And could you describe the copyright status? Stefan