From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Patch to trunk: merge common code in hourglass impl Date: Wed, 04 Jun 2008 01:53:19 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212558830 14703 80.91.229.12 (4 Jun 2008 05:53:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2008 05:53:50 +0000 (UTC) Cc: emacs- devel To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 04 07:54:31 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K3lx6-0003yW-Ge for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 07:54:28 +0200 Original-Received: from localhost ([127.0.0.1]:45941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3lwK-0007jk-2k for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 01:53:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3lwE-0007jf-5b for emacs-devel@gnu.org; Wed, 04 Jun 2008 01:53:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3lwB-0007jQ-Q5 for emacs-devel@gnu.org; Wed, 04 Jun 2008 01:53:33 -0400 Original-Received: from [199.232.76.173] (port=38253 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3lwB-0007jN-7f for emacs-devel@gnu.org; Wed, 04 Jun 2008 01:53:31 -0400 Original-Received: from 206-248-132-168.dsl.teksavvy.com ([206.248.132.168]:53733 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K3lwB-0005Yd-2o for emacs-devel@gnu.org; Wed, 04 Jun 2008 01:53:31 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id E7B54B423C; Wed, 4 Jun 2008 01:53:19 -0400 (EDT) In-Reply-To: (Adrian Robert's message of "Tue, 3 Jun 2008 20:05:27 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98365 Archived-At: > When I updated the hourglass implementation in the NS (Cocoa) port for the > hourglass changes of 2008-03-19 I put some code that was duplicated in > {x,mac,w32}fns.c into xdisp.c, leaving only {show,hide}_hourglass functions > for the port to implement. Other GUIs could use this common code as well, > and here is a patch against trunk to do so. > There are three issues: > - I have tested only the X version. > - Under W32, atimers are not currently used, so the common code cannot be > either. If atimers will work under W32, then the patch can be improved to > benefit W32 as well. It would be good to know if the avoidance of atimers was done on purpose. Eli? Jason? > - Under Mac, the hourglass impl is under #ifdef MAC_OSX. I replicate this > constraint in xdisp.c as "#if !defined (MAC_OS) || defined (MAC_OSX)". > Hopefully this is correct. A similar problem exists for the tty-only version. I think the code needs to check HAVE_WINDOW_SYSTEM. Not sure what's up with the MAC_OS-non-MAC_OSX code. Now that we do not support MAC_OS8 any more, MAC_OS-non-MAC_OSX should be impossible (and since the Carbon code is broken anyway, there's no good reason to worry about it, really). Stefan