From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: emacs- devel <emacs-devel@gnu.org>
Subject: Re: Patch to trunk: merge common code in hourglass impl
Date: Wed, 04 Jun 2008 01:53:19 -0400 [thread overview]
Message-ID: <jwvskvtiwfo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <BD039C62-DF60-4BC5-A6E5-9703D300EED1@gmail.com> (Adrian Robert's message of "Tue, 3 Jun 2008 20:05:27 -0400")
> When I updated the hourglass implementation in the NS (Cocoa) port for the
> hourglass changes of 2008-03-19 I put some code that was duplicated in
> {x,mac,w32}fns.c into xdisp.c, leaving only {show,hide}_hourglass functions
> for the port to implement. Other GUIs could use this common code as well,
> and here is a patch against trunk to do so.
> There are three issues:
> - I have tested only the X version.
> - Under W32, atimers are not currently used, so the common code cannot be
> either. If atimers will work under W32, then the patch can be improved to
> benefit W32 as well.
It would be good to know if the avoidance of atimers was done
on purpose. Eli? Jason?
> - Under Mac, the hourglass impl is under #ifdef MAC_OSX. I replicate this
> constraint in xdisp.c as "#if !defined (MAC_OS) || defined (MAC_OSX)".
> Hopefully this is correct.
A similar problem exists for the tty-only version. I think the code
needs to check HAVE_WINDOW_SYSTEM.
Not sure what's up with the MAC_OS-non-MAC_OSX code. Now that we do not
support MAC_OS8 any more, MAC_OS-non-MAC_OSX should be impossible (and
since the Carbon code is broken anyway, there's no good reason to worry
about it, really).
Stefan
next prev parent reply other threads:[~2008-06-04 5:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 0:05 Patch to trunk: merge common code in hourglass impl Adrian Robert
2008-06-04 5:53 ` Stefan Monnier [this message]
2008-06-04 9:31 ` Jason Rumney
2008-06-04 16:17 ` Stefan Monnier
2008-06-04 17:31 ` Eli Zaretskii
2008-06-04 21:31 ` Jason Rumney
2008-06-04 21:38 ` Lennart Borgman (gmail)
2008-06-06 20:00 ` Eli Zaretskii
2008-07-15 0:46 ` Adrian Robert
2008-07-15 1:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvskvtiwfo.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=adrian.b.robert@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).